CLDSRV-741: Reorganize some cold storage tests #5953

BourgoisMickael · 2025-09-25T21:16:29Z

To replace condition on S3_END_TO_END with by cold storage feature presence

To run header validation tests even in S3C

No new tests, just reorganization

Test should fail if version id is invalid doesn't need to fakeMetadataArchive, it's been simplified.

The big diff is indentation

codecov · 2025-09-25T21:18:54Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.31%. Comparing base (23fc025) to head (a817615).
⚠️ Report is 6 commits behind head on development/9.0.
✅ All tests successful. No failed tests found.

Additional details and impacted files

@@               Coverage Diff                @@
##           development/9.0    #5953   +/-   ##
================================================
  Coverage            83.31%   83.31%           
================================================
  Files                  189      189           
  Lines                12147    12147           
================================================
  Hits                 10120    10120           
  Misses                2027     2027

Flag	Coverage Δ
ceph-backend-test	`65.78% <ø> (ø)`
file-ft-tests	`66.69% <ø> (+0.25%)`	⬆️
kmip-ft-tests	`27.02% <ø> (ø)`
mongo-v0-ft-tests	`68.00% <ø> (-0.03%)`	⬇️
mongo-v1-ft-tests	`68.00% <ø> (ø)`
multiple-backend	`35.53% <ø> (ø)`
quota-tests	`32.28% <ø> (-0.89%)`	⬇️
quota-tests-inflights	`34.25% <ø> (ø)`
unit	`67.42% <ø> (ø)`
utapi-v2-tests	`33.42% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copilot

Pull Request Overview

This PR reorganizes cold storage tests by replacing the condition based on S3_END_TO_END environment variable with checking for cold storage feature presence using config.hasColdStorage. The changes enable header validation tests to run even in S3C environments while properly separating cold storage-specific functionality.

Replaced process.env.S3_END_TO_END conditions with config.hasColdStorage checks
Moved header validation tests outside of cold storage conditional blocks
Reorganized test structure to separate general validation from cold storage-specific tests

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File	Description
putVersion.js	Reorganized PUT object version tests to separate header validation from cold storage functionality
mpuVersion.js	Reorganized multipart upload version tests with same pattern as putVersion.js
copyPart.js	Updated cold storage test conditions to use config-based feature detection

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

tests/functional/aws-node-sdk/test/object/putVersion.js

tests/functional/aws-node-sdk/test/object/mpuVersion.js

To replace condition on S3_END_TO_END with by cold storage condition To run header validation tests even in S3C No new tests, just reorganization

bert-e · 2025-09-27T01:46:39Z

Hello bourgoismickael,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options

name	description	privileged	authored
`/after_pull_request`	Wait for the given pull request id to be merged before continuing with the current one.
`/bypass_author_approval`	Bypass the pull request author's approval	⭐
`/bypass_build_status`	Bypass the build and test status	⭐
`/bypass_commit_size`	Bypass the check on the size of the changeset `TBA`	⭐
`/bypass_incompatible_branch`	Bypass the check on the source branch prefix	⭐
`/bypass_jira_check`	Bypass the Jira issue check	⭐
`/bypass_peer_approval`	Bypass the pull request peers' approval	⭐
`/bypass_leader_approval`	Bypass the pull request leaders' approval	⭐
`/approve`	Instruct Bert-E that the author has approved the pull request.		✍️
`/create_pull_requests`	Allow the creation of integration pull requests.
`/create_integration_branches`	Allow the creation of integration branches.
`/no_octopus`	Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
`/unanimity`	Change review acceptance criteria from `one reviewer at least` to `all reviewers`
`/wait`	Instruct Bert-E not to run until further notice.

Available commands

name	description	privileged
`/help`	Print Bert-E's manual in the pull request.
`/status`	Print Bert-E's current status in the pull request `TBA`
`/clear`	Remove all comments from Bert-E from the history `TBA`
`/retry`	Re-start a fresh build `TBA`
`/build`	Re-start a fresh build `TBA`
`/force_reset`	Delete integration branches & pull requests, and restart merge process from the beginning.
`/reset`	Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

bert-e · 2025-09-27T01:46:46Z

Request integration branches

Waiting for integration branch creation to be requested by the user.

To request integration branches, please comment on this pull request with the following command:

/create_integration_branches

Alternatively, the /approve and /create_pull_requests commands will automatically
create the integration branches.

BourgoisMickael · 2025-09-29T14:26:17Z

/approve

bert-e · 2025-09-29T14:26:27Z

Conflict

A conflict has been raised during the creation of
integration branch w/9.1/improvement/CLDSRV-741-tests-restore with contents from improvement/CLDSRV-741-tests-restore
and development/9.1.

I have not created the integration branch.

Here are the steps to resolve this conflict:

 git fetch
 git checkout -B w/9.1/improvement/CLDSRV-741-tests-restore origin/development/9.1
 git merge origin/improvement/CLDSRV-741-tests-restore
 # <intense conflict resolution>
 git commit
 git push -u origin w/9.1/improvement/CLDSRV-741-tests-restore

The following options are set: approve

bert-e · 2025-09-29T16:16:39Z

Build failed

The build for commit did not succeed in branch w/9.1/improvement/CLDSRV-741-tests-restore

The following options are set: approve

BourgoisMickael · 2025-09-29T16:19:45Z

/create_pull_requests

bert-e · 2025-09-29T16:19:59Z

Integration data created

I have created the integration data for the additional destination branches.

this pull request will merge improvement/CLDSRV-741-tests-restore into
development/9.0
w/9.1/improvement/CLDSRV-741-tests-restore will be merged into development/9.1 (pull request INTEGRATION [PR#5953 > development/9.1] CLDSRV-741: Reorganize some cold storage tests #5959)

The following branches will NOT be impacted:

development/7.10
development/7.4
development/7.70
development/8.8

Follow integration pull requests if you would like to be notified of
build statuses by email.

The following options are set: approve, create_pull_requests

bert-e · 2025-09-29T16:20:01Z

Build failed

The build for commit did not succeed in branch w/9.1/improvement/CLDSRV-741-tests-restore

The following options are set: approve, create_pull_requests

bert-e · 2025-09-30T02:09:38Z

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

✔️ development/9.0
✔️ development/9.1

The following branches will NOT be impacted:

development/7.10
development/7.4
development/7.70
development/8.8

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

Any commit you add on the source branch will trigger a new cycle after the
current queue is merged.
Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve, create_pull_requests

bert-e · 2025-09-30T02:47:50Z

Queue build failed

The corresponding build for the queue failed:

Checkout the status page.
Identify the failing build and review the logs.
If no issue is found, re-run the build.
If an issue is identified, checkout the steps below to remove
the pull request from the queue for further analysis and maybe rebase/merge.

Remove the pull request from the queue

Add a /wait comment on this pull request.
Click on login on the status page.
Go into the manage page.
Find the option called Rebuild the queue and click on it.
Bert-E will loop again on all pull requests to put the valid ones
in the queue again, while skipping the one with the /wait comment.
Wait for the new queue to merge, then merge/rebase your pull request
with the latest changes to then work on a proper fix.
Once the issue is fixed, delete the /wait comment and
follow the usual process to merge the pull request.

bert-e · 2025-09-30T03:14:33Z

I have successfully merged the changeset of this pull request
into targetted development branches:

✔️ development/9.0
✔️ development/9.1

The following branches have NOT changed:

development/7.10
development/7.4
development/7.70
development/8.8

Please check the status of the associated issue CLDSRV-741.

Goodbye bourgoismickael.

BourgoisMickael requested a review from Copilot September 25, 2025 21:26

Copilot AI reviewed Sep 25, 2025

View reviewed changes

tests/functional/aws-node-sdk/test/object/putVersion.js Outdated Show resolved Hide resolved

tests/functional/aws-node-sdk/test/object/mpuVersion.js Outdated Show resolved Hide resolved

BourgoisMickael force-pushed the improvement/CLDSRV-741-tests-restore branch from dcd6575 to f1df2a9 Compare September 25, 2025 22:08

BourgoisMickael requested review from a team, DarkIsDude, Kerkesni, dvasilas, fredmnl and williamlardier and removed request for a team September 26, 2025 16:16

BourgoisMickael mentioned this pull request Sep 26, 2025

CLDSRV-741: Validate notification event usage #5952

Merged

BourgoisMickael force-pushed the improvement/CLDSRV-741-notification-block-events branch from de2bbb1 to 8d966fb Compare September 26, 2025 18:36

CLDSRV-741: Reorganize some cold storage tests

a817615

To replace condition on S3_END_TO_END with by cold storage condition To run header validation tests even in S3C No new tests, just reorganization

BourgoisMickael force-pushed the improvement/CLDSRV-741-tests-restore branch from f1df2a9 to a817615 Compare September 27, 2025 01:46

BourgoisMickael changed the base branch from improvement/CLDSRV-741-notification-block-events to development/9.0 September 27, 2025 01:46

anurag4DSB approved these changes Sep 29, 2025

View reviewed changes

williamlardier approved these changes Sep 29, 2025

View reviewed changes

bert-e mentioned this pull request Sep 29, 2025

INTEGRATION [PR#5953 > development/9.1] CLDSRV-741: Reorganize some cold storage tests #5959

Merged

bert-e merged commit db120d3 into development/9.0 Sep 30, 2025
27 checks passed

bert-e deleted the improvement/CLDSRV-741-tests-restore branch September 30, 2025 03:14

CLDSRV-741: Reorganize some cold storage tests #5953

CLDSRV-741: Reorganize some cold storage tests #5953

Uh oh!

Conversation

BourgoisMickael commented Sep 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Sep 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

bert-e commented Sep 27, 2025

Hello bourgoismickael,

Uh oh!

bert-e commented Sep 27, 2025

Request integration branches

Uh oh!

BourgoisMickael commented Sep 29, 2025

Uh oh!

bert-e commented Sep 29, 2025

Conflict

Uh oh!

bert-e commented Sep 29, 2025

Build failed

Uh oh!

BourgoisMickael commented Sep 29, 2025

Uh oh!

bert-e commented Sep 29, 2025

Integration data created

Uh oh!

bert-e commented Sep 29, 2025

Build failed

Uh oh!

bert-e commented Sep 30, 2025

In the queue

Uh oh!

bert-e commented Sep 30, 2025

Queue build failed

Uh oh!

bert-e commented Sep 30, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

BourgoisMickael commented Sep 25, 2025 •

edited

Loading

codecov bot commented Sep 25, 2025 •

edited

Loading