Skip to content

Conversation

@BourgoisMickael
Copy link
Contributor

@BourgoisMickael BourgoisMickael commented Jan 20, 2026

The test was flaky due to stricter tolerance on load distribution across KMIP nodes.

Enhanced error message to include deviation details for better debugging.

The test was flaky due to stricter tolerance on load distribution across KMIP nodes.
Enhanced error message to include deviation details for better debugging.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@bert-e
Copy link
Contributor

bert-e commented Jan 20, 2026

Hello bourgoismickael,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Jan 20, 2026

Incorrect fix version

The Fix Version/s in issue CLDSRV-829 contains:

  • None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 7.70.78

  • 8.8.60

  • 9.0.36

  • 9.1.9

  • 9.2.16

  • 9.3.0

Please check the Fix Version/s of CLDSRV-829, or the target
branch of this pull request.

@BourgoisMickael
Copy link
Contributor Author

ping

@bert-e
Copy link
Contributor

bert-e commented Jan 20, 2026

Request integration branches

Waiting for integration branch creation to be requested by the user.

To request integration branches, please comment on this pull request with the following command:

/create_integration_branches

Alternatively, the /approve and /create_pull_requests commands will automatically
create the integration branches.

@BourgoisMickael
Copy link
Contributor Author

/create_integration_branches

@bert-e
Copy link
Contributor

bert-e commented Jan 20, 2026

Conflict

A conflict has been raised during the creation of
integration branch w/9.3/improvement/CLDSRV-829-flaky-kms-load-repartition with contents from w/9.2/improvement/CLDSRV-829-flaky-kms-load-repartition
and development/9.3.

I have not created the integration branch.

Here are the steps to resolve this conflict:

 git fetch
 git checkout -B w/9.3/improvement/CLDSRV-829-flaky-kms-load-repartition origin/development/9.3
 git merge origin/w/9.2/improvement/CLDSRV-829-flaky-kms-load-repartition
 # <intense conflict resolution>
 git commit
 git push -u origin w/9.3/improvement/CLDSRV-829-flaky-kms-load-repartition

The following options are set: create_integration_branches

@bert-e
Copy link
Contributor

bert-e commented Jan 20, 2026

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

The following options are set: create_integration_branches

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses test flakiness in the KMS load test by relaxing the tolerance for load distribution across KMIP nodes from 10% to 20%. The change acknowledges that the round-robin distribution of requests is confined to individual Node.js cluster processes, which can lead to natural variance in packet distribution that exceeds the previous 10% threshold.

Changes:

  • Increased the load distribution tolerance from 10% to 20% to reduce test flakiness
  • Enhanced the error message to include deviation details (±APPROX, min, max values) for better debugging

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@BourgoisMickael BourgoisMickael requested review from a team, anurag4DSB, benzekrimaha and jonathan-gramain and removed request for a team January 20, 2026 05:30
@BourgoisMickael
Copy link
Contributor Author

/approve

@bert-e
Copy link
Contributor

bert-e commented Jan 20, 2026

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ development/7.70

  • ✔️ development/8.8

  • ✔️ development/9.0

  • ✔️ development/9.1

  • ✔️ development/9.2

  • ✔️ development/9.3

The following branches will NOT be impacted:

  • development/7.10
  • development/7.4

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve, create_integration_branches

@bert-e
Copy link
Contributor

bert-e commented Jan 20, 2026

Queue build failed

The corresponding build for the queue failed:

  • Checkout the status page.
  • Identify the failing build and review the logs.
  • If no issue is found, re-run the build.
  • If an issue is identified, checkout the steps below to remove
    the pull request from the queue for further analysis and maybe rebase/merge.
Remove the pull request from the queue
  • Add a /wait comment on this pull request.
  • Click on login on the status page.
  • Go into the manage page.
  • Find the option called Rebuild the queue and click on it.
    Bert-E will loop again on all pull requests to put the valid ones
    in the queue again, while skipping the one with the /wait comment.
  • Wait for the new queue to merge, then merge/rebase your pull request
    with the latest changes to then work on a proper fix.
  • Once the issue is fixed, delete the /wait comment and
    follow the usual process to merge the pull request.

@bert-e
Copy link
Contributor

bert-e commented Jan 20, 2026

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/7.70

  • ✔️ development/8.8

  • ✔️ development/9.0

  • ✔️ development/9.1

  • ✔️ development/9.2

  • ✔️ development/9.3

The following branches have NOT changed:

  • development/7.10
  • development/7.4

Please check the status of the associated issue CLDSRV-829.

Goodbye bourgoismickael.

@bert-e bert-e merged commit 95a57b3 into development/7.70 Jan 20, 2026
40 checks passed
@bert-e bert-e deleted the improvement/CLDSRV-829-flaky-kms-load-repartition branch January 20, 2026 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants