🎨 format on bucketGet and objectGetLegalHold for async/await#6073
🎨 format on bucketGet and objectGetLegalHold for async/await#6073DarkIsDude wants to merge 2 commits intodevelopment/9.3from
Conversation
Hello darkisdude,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
ConflictThere is a conflict between your branch Please resolve the conflict on the feature branch ( git fetch && \
git checkout origin/feature/CLDSRV-823/formatting-only && \
git merge origin/development/9.3Resolve merge conflicts and commit git push origin HEAD:feature/CLDSRV-823/formatting-only |
7559941 to
99b9108
Compare
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
|
❌ 1 Tests Failed:
View the top 1 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
maeldonn
left a comment
There was a problem hiding this comment.
What the goal of this PR ? We should wait the validation of the prettier configuration before starting formatting files. It can lead to unnecessary conflicts...
You have the reason of this PR here #6045 (comment). Prettier can fix some stuff but not all of them and I hope that we'll not do a one shot with prettier but first add prettier and will validate only file that are in the diff and after some months migrate remaining one, because if we do that, we'll have conflicts on all PR. Also prettier will not be able to fix everything and we'll always need to do some manual work. |
Issue: CLDSRV-823
Pull request template
Description
Motivation and context
Why is this change required? What problem does it solve?
Related issues
Please use the following link syntaxes #600 to reference issues in the
current repository
Checklist
Add tests to cover the changes
New tests added or existing tests modified to cover all changes
Code conforms with the style guide
Sign your work
In order to contribute to the project, you must sign your work
https://github.com/scality/Guidelines/blob/master/CONTRIBUTING.md#sign-your-work
Thank you again for contributing! We will try to test and integrate the change
as soon as we can.