Improvement/cldsrv 561 add tests for create and store object by benzekrimaha · Pull Request #6082 · scality/cloudserver

benzekrimaha · 2026-02-23T09:34:22Z

This PR strengthens coverage around createAndStoreObject, the core path used by putObject, putRestoredObject, and putObjectVersion, with emphasis on cold-storage restore and archived-object edge cases.
The goal is to improve confidence in behavior-heavy flows
Issue: CLDSRV-561

bert-e · 2026-02-23T09:34:25Z

Hello benzekrimaha,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options

name	description	privileged	authored
`/after_pull_request`	Wait for the given pull request id to be merged before continuing with the current one.
`/bypass_author_approval`	Bypass the pull request author's approval	⭐
`/bypass_build_status`	Bypass the build and test status	⭐
`/bypass_commit_size`	Bypass the check on the size of the changeset `TBA`	⭐
`/bypass_incompatible_branch`	Bypass the check on the source branch prefix	⭐
`/bypass_jira_check`	Bypass the Jira issue check	⭐
`/bypass_peer_approval`	Bypass the pull request peers' approval	⭐
`/bypass_leader_approval`	Bypass the pull request leaders' approval	⭐
`/approve`	Instruct Bert-E that the author has approved the pull request.		✍️
`/create_pull_requests`	Allow the creation of integration pull requests.
`/create_integration_branches`	Allow the creation of integration branches.
`/no_octopus`	Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
`/unanimity`	Change review acceptance criteria from `one reviewer at least` to `all reviewers`
`/wait`	Instruct Bert-E not to run until further notice.

Available commands

name	description	privileged
`/help`	Print Bert-E's manual in the pull request.
`/status`	Print Bert-E's current status in the pull request `TBA`
`/clear`	Remove all comments from Bert-E from the history `TBA`
`/retry`	Re-start a fresh build `TBA`
`/build`	Re-start a fresh build `TBA`
`/force_reset`	Delete integration branches & pull requests, and restart merge process from the beginning.
`/reset`	Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

bert-e · 2026-02-23T09:34:30Z

Incorrect fix version

The Fix Version/s in issue CLDSRV-561 contains:

None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

9.3.4

Please check the Fix Version/s of CLDSRV-561, or the target
branch of this pull request.

codecov · 2026-02-23T09:41:00Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.24%. Comparing base (2a7a68f) to head (a26bb42).
⚠️ Report is 69 commits behind head on development/9.3.
✅ All tests successful. No failed tests found.

Additional details and impacted files

see 3 files with indirect coverage changes

@@                 Coverage Diff                 @@
##           development/9.3    #6082      +/-   ##
===================================================
- Coverage            84.31%   84.24%   -0.07%     
===================================================
  Files                  206      206              
  Lines                13251    13251              
===================================================
- Hits                 11172    11163       -9     
- Misses                2079     2088       +9

Flag	Coverage Δ
file-ft-tests	`67.92% <ø> (+<0.01%)`	⬆️
kmip-ft-tests	`28.08% <ø> (-0.04%)`	⬇️
mongo-v0-ft-tests	`69.24% <ø> (+0.10%)`	⬆️
mongo-v1-ft-tests	`69.25% <ø> (+0.03%)`	⬆️
multiple-backend	`35.10% <ø> (ø)`
sur-tests	`35.63% <ø> (-0.04%)`	⬇️
sur-tests-inflights	`37.47% <ø> (-0.02%)`	⬇️
unit	`69.90% <ø> (ø)`
utapi-v2-tests	`34.36% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

bert-e · 2026-02-23T09:41:11Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
2 peers

bert-e · 2026-02-24T08:52:09Z

Incorrect fix version

The Fix Version/s in issue CLDSRV-561 contains:

9.3.4

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

9.3.5

Please check the Fix Version/s of CLDSRV-561, or the target
branch of this pull request.

bert-e · 2026-02-24T09:05:25Z

Incorrect fix version

The Fix Version/s in issue CLDSRV-561 contains:

None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

9.3.5

Please check the Fix Version/s of CLDSRV-561, or the target
branch of this pull request.

bert-e · 2026-02-24T11:12:11Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
2 peers

francoisferrand

Looking at code coverage (https://app.codecov.io/github/scality/cloudserver/pull/6082/blob/lib/api/apiUtils/object/createAndStoreObject.js?dropdown=coverage), we can confirm createAndStoreObject is already reletively well "covered".

There are some gaps indeed, but this PR does not cover them.

However, the missing parts is also sometimes more subtle, and requires checking the actual behavior : like do we set the right arsenal flag (needOplogUpdate)...

So it is not just adding tests:

need to dig deeper to identify the specific behaviors which must be implemented by this function (like when to require oplog update, the originOp, etc...)
then either find the tests which already cover these cases (there are some, c.f. coverage) and update them; or indeed add some extra tests to validate these specific behaviors

tests/functional/aws-node-sdk/test/object/objectOverwrite.js

bert-e · 2026-02-25T16:39:02Z

Incorrect fix version

The Fix Version/s in issue CLDSRV-561 contains:

9.3.5

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

9.3.5
9.4.0

Please check the Fix Version/s of CLDSRV-561, or the target
branch of this pull request.

bert-e · 2026-02-27T15:39:36Z

Request integration branches

Waiting for integration branch creation to be requested by the user.

To request integration branches, please comment on this pull request with the following command:

/create_integration_branches

Alternatively, the /approve and /create_pull_requests commands will automatically
create the integration branches.

SylvainSenechal

wouldn't we want (some of) these tests to be in zenko, to avoid relying on mocks ? I guess should be possible, running mongo commands to directly inspect database data

francoisferrand · 2026-03-11T08:43:29Z

wouldn't we want (some of) these tests to be in zenko, to avoid relying on mocks ? I guess should be possible, running mongo commands to directly inspect database data

some (if not all) of these tests are already in Zenko, as part of functional / e2e tests : i.e. can we restore an object (in the various cases)? do we get the proper bucket notification? ... But IMHO "too late" (in the dev process) to inspect mongo content in Zenko tests.

relying on mocks is good to test corner cases, and ideally we would have integration tests to cross-check the actual backend works as expected: i.e. running some tests against mongo to verify it behaves as expected. How relevant (or not) the integration tests are really depends on the specific case: e.g. if we are already sure mongo (or metadata) write the object MD as we provide them, then good enough to verify we call this metadata layer with the right information....

But we should try to keep these tests as close to the code as possible: i.e. we want to make sure Cloudserver behaves as expected with mongo backend, should be done here (but integration between backbeat and cloudserver would probably be in Zenko)

tests/functional/aws-node-sdk/test/object/objectOverwrite.js

tests/unit/api/createAndStoreObject.js

claude · 2026-03-25T08:50:54Z

tests/unit/api/createAndStoreObject.js:121 — Extra }); prematurely closes the outer describe('createAndStoreObject') block. All test suites after 'Regular object creation' lose access to beforeEach/afterEach hooks (testBucket setup, cleanup(), sinon.restore()), meaning those tests either fail or pass without proper isolation.

Review by Claude Code

tests/functional/aws-node-sdk/test/object/putVersion.js

claude · 2026-03-25T09:03:11Z

putVersion.js: promisify wrappers are redundant — the functions already return promises when called without a callback (dual-mode refactoring in this same PR's init.js changes).

Review by Claude Code

tests/functional/aws-node-sdk/test/object/putVersion.js

claude · 2026-03-25T15:19:05Z

Unnecessary async IIFE in putObjectVersion (putVersion.js:52-55): s3.send(command) already returns a promise, the (async () => { ... })() wrapper is redundant.

Review by Claude Code

claude · 2026-03-26T05:50:15Z

LGTM

The dual callback/promise pattern in init.js (cb ? promise.then(..., cb) : promise) is correct and properly follows Node.js error-first conventions. The putObjectVersion refactor also fixes the previous double-callback anti-pattern (where next was called inside a try block and could be called again in catch).

Review by Claude Code

Issue: CLDSRV-561

claude · 2026-03-26T06:33:13Z

LGTM

The callback-to-dual-callback/promise migration in init.js is clean and the new test coverage for createAndStoreObject (cold-storage restore, versioning, archived-object edge cases) is solid.

Review by Claude Code

benzekrimaha · 2026-03-26T06:44:48Z

/create_integration_branches

bert-e · 2026-03-26T06:44:59Z

Integration data created

I have created the integration data for the additional destination branches.

this pull request will merge improvement/CLDSRV-561-add-tests-for-createAndStoreObject into
development/9.3
w/9.4/improvement/CLDSRV-561-add-tests-for-createAndStoreObject will be merged into development/9.4

The following branches will NOT be impacted:

development/7.10
development/7.4
development/7.70
development/8.8
development/9.0
development/9.1
development/9.2

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

The following options are set: create_integration_branches

bert-e · 2026-03-26T06:45:00Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
2 peers

The following options are set: create_integration_branches

benzekrimaha · 2026-03-26T06:47:19Z

@bert-e create_pull_requests

bert-e · 2026-03-26T06:47:30Z

Integration data created

I have created the integration data for the additional destination branches.

this pull request will merge improvement/CLDSRV-561-add-tests-for-createAndStoreObject into
development/9.3
w/9.4/improvement/CLDSRV-561-add-tests-for-createAndStoreObject will be merged into development/9.4 (pull request INTEGRATION [PR#6082 > development/9.4] Improvement/cldsrv 561 add tests for create and store object #6120)

The following branches will NOT be impacted:

development/7.10
development/7.4
development/7.70
development/8.8
development/9.0
development/9.1
development/9.2

Follow integration pull requests if you would like to be notified of
build statuses by email.

The following options are set: create_pull_requests, create_integration_branches

bert-e · 2026-03-26T06:47:31Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
2 peers

The following options are set: create_pull_requests, create_integration_branches

benzekrimaha · 2026-03-26T06:49:17Z

/approve

bert-e · 2026-03-26T07:09:29Z

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

✔️ development/9.3
✔️ development/9.4

The following branches will NOT be impacted:

development/7.10
development/7.4
development/7.70
development/8.8
development/9.0
development/9.1
development/9.2

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

Any commit you add on the source branch will trigger a new cycle after the
current queue is merged.
Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve, create_pull_requests, create_integration_branches

bert-e · 2026-03-26T07:32:54Z

I have successfully merged the changeset of this pull request
into targetted development branches:

✔️ development/9.3
✔️ development/9.4

The following branches have NOT changed:

development/7.10
development/7.4
development/7.70
development/8.8
development/9.0
development/9.1
development/9.2

Please check the status of the associated issue CLDSRV-561.

Goodbye benzekrimaha.

benzekrimaha force-pushed the improvement/CLDSRV-561-add-tests-for-createAndStoreObject branch from c6e0798 to dddff1b Compare February 24, 2026 08:52

benzekrimaha force-pushed the improvement/CLDSRV-561-add-tests-for-createAndStoreObject branch from dddff1b to 84844ff Compare February 24, 2026 08:53

benzekrimaha force-pushed the improvement/CLDSRV-561-add-tests-for-createAndStoreObject branch from 0f0e6e9 to 57227d6 Compare February 24, 2026 11:10

benzekrimaha marked this pull request as ready for review February 24, 2026 11:11

benzekrimaha requested a review from francoisferrand February 24, 2026 11:12

benzekrimaha requested review from a team and SylvainSenechal February 24, 2026 11:12

francoisferrand reviewed Feb 24, 2026

View reviewed changes

benzekrimaha requested a review from francoisferrand February 27, 2026 15:39

SylvainSenechal approved these changes Feb 27, 2026

View reviewed changes

benzekrimaha requested review from a team and delthas March 4, 2026 09:48

scality deleted a comment from bert-e Mar 16, 2026

francoisferrand reviewed Mar 16, 2026

View reviewed changes

tests/functional/aws-node-sdk/test/object/objectOverwrite.js Outdated Show resolved Hide resolved

francoisferrand reviewed Mar 16, 2026

View reviewed changes

tests/functional/aws-node-sdk/test/object/objectOverwrite.js Outdated Show resolved Hide resolved

francoisferrand approved these changes Mar 16, 2026

View reviewed changes

tests/unit/api/createAndStoreObject.js Outdated Show resolved Hide resolved

delthas removed their request for review March 20, 2026 08:33

claude bot reviewed Mar 25, 2026

View reviewed changes

tests/unit/api/createAndStoreObject.js Outdated Show resolved Hide resolved

claude bot reviewed Mar 25, 2026

View reviewed changes

tests/functional/aws-node-sdk/test/object/putVersion.js Outdated Show resolved Hide resolved

claude bot reviewed Mar 25, 2026

View reviewed changes

tests/functional/aws-node-sdk/test/object/putVersion.js Outdated Show resolved Hide resolved

benzekrimaha added 4 commits March 26, 2026 07:29

promise-first metadata test helpers

32ef85d

Issue: CLDSRV-561

add async createAndStoreObject unit suite

aa9b722

Issue: CLDSRV-561

simplify cold-state overwrite flow

423fa32

Issue: CLDSRV-561

streamline putVersion helper usage

a26bb42

Issue: CLDSRV-561

benzekrimaha force-pushed the improvement/CLDSRV-561-add-tests-for-createAndStoreObject branch from b6f83bc to a26bb42 Compare March 26, 2026 06:31

bert-e mentioned this pull request Mar 26, 2026

INTEGRATION [PR#6082 > development/9.4] Improvement/cldsrv 561 add tests for create and store object #6120

Closed

bert-e merged commit 686200b into development/9.3 Mar 26, 2026
30 checks passed

bert-e deleted the improvement/CLDSRV-561-add-tests-for-createAndStoreObject branch March 26, 2026 07:32

Conversation

benzekrimaha commented Feb 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bert-e commented Feb 23, 2026

Hello benzekrimaha,

Uh oh!

bert-e commented Feb 23, 2026

Incorrect fix version

Uh oh!

codecov bot commented Feb 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

bert-e commented Feb 23, 2026

Waiting for approval

Uh oh!

bert-e commented Feb 24, 2026

Incorrect fix version

Uh oh!

bert-e commented Feb 24, 2026

Incorrect fix version

Uh oh!

bert-e commented Feb 24, 2026

Waiting for approval

Uh oh!

francoisferrand left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bert-e commented Feb 25, 2026

Incorrect fix version

Uh oh!

bert-e commented Feb 27, 2026

Request integration branches

Uh oh!

SylvainSenechal left a comment

Choose a reason for hiding this comment

Uh oh!

francoisferrand commented Mar 11, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

claude bot commented Mar 25, 2026

Uh oh!

Uh oh!

claude bot commented Mar 25, 2026

Uh oh!

Uh oh!

claude bot commented Mar 25, 2026

Uh oh!

claude bot commented Mar 26, 2026

Uh oh!

claude bot commented Mar 26, 2026

Uh oh!

benzekrimaha commented Mar 26, 2026

Uh oh!

bert-e commented Mar 26, 2026

Integration data created

Uh oh!

bert-e commented Mar 26, 2026

Waiting for approval

Uh oh!

benzekrimaha commented Mar 26, 2026

Uh oh!

bert-e commented Mar 26, 2026

Integration data created

Uh oh!

bert-e commented Mar 26, 2026

Waiting for approval

Uh oh!

benzekrimaha commented Mar 26, 2026

Uh oh!

bert-e commented Mar 26, 2026

benzekrimaha commented Feb 23, 2026 •

edited

Loading

codecov bot commented Feb 23, 2026 •

edited

Loading