INTEGRATION [PR#6121 > development/9.2] š use SUR date instead of the infostore one to have an update LastModā¦#6134
Conversation
ā¦ified date Issue: CLDSRV-878
Call UtilizationService.getUtilizationMetrics for capacity.xml on the HEAD and LIST routes, mirroring the existing pattern from GET. This ensures Last-Modified is derived from SUR metrics (not stale metadata) on all three routes. Fall back to new Date() when metrics are unavailable (404) or absent. Also use new Date() as the fallback in GET instead of the stored LastModified value. Issue: CLDSRV-878
Move the shared UtilizationService call pattern (bucket key derivation, 404 warn/fallback, error logging) into a single fetchCapacityMetrics helper in utils.js, used by GET, HEAD, and LIST routes. Issue: CLDSRV-878
Issue: CLDSRV-878
ā¦into w/9.2/bugfix/CLDSRV-878/use-sur-date
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
| throw errors.InternalError; | ||
| } | ||
| } else { | ||
| bucketMetrics = { date: new Date() }; |
There was a problem hiding this comment.
buildVeeamFileData sets bucketMetrics = { date: new Date() } for system.xml (line 284-285), so the modified date is always the current date. But getFileToBuild (line 202) computes modified = fileToBuild.LastModified || new Date() and discards it ā the stored LastModified from metadata is never returned.
This is a behavioral change for system.xml: the Last-Modified header used to reflect the date the file was PUT; now it always returns the current date. It also creates an inconsistency with list.js, which still uses file.LastModified (the stored date) for system.xml entries (list.js line 128-130).
Consider returning modified from getFileToBuild so GET/HEAD can use the stored date for system.xml, matching LIST behavior.
ā Claude Code
| * @returns {undefined} - | ||
| */ | ||
| function getVeeamFile(request, response, bucketMd, log) { | ||
| async function getVeeamFile(request, response, bucketMd, log) { |
There was a problem hiding this comment.
getVeeamFile, headVeeamFile, and listVeeamFiles are now async, but the caller in routeVeeam.js:167 (return callback(request, response, bucketMd, log)) does not handle the returned promise. If an unexpected error escapes the try/catch blocks (e.g. a TypeError), it becomes an unhandled promise rejection, which crashes the process in modern Node.js.
Consider adding a .catch() at the call site in routeVeeam.js, or wrapping the invocation. The handlers themselves look solid ā the risk is at the call site in routeVeeam.js which is not updated in this PR.
ā Claude Code
Review by Claude Code |
2 participants
This pull request has been created automatically.
It is linked to its parent pull request #6121.
Do not edit this pull request directly.
If you need to amend/cancel the changeset on branch
w/9.2/bugfix/CLDSRV-878/use-sur-date, please follow thisprocedure:
git fetch git checkout w/9.2/bugfix/CLDSRV-878/use-sur-date # <amend or cancel the changeset by _adding_ new commits> git push origin w/9.2/bugfix/CLDSRV-878/use-sur-datePlease always comment pull request #6121 instead of this one.