Skip to content

INTEGRATION [PR#6088 > development/9.4] 👷(CLDSRV-860) Monitor async await migration#6151

Merged
bert-e merged 13 commits intodevelopment/9.4from
w/9.4/feature/CLDSRV-860/monitor-async-await-migration
Apr 15, 2026
Merged

INTEGRATION [PR#6088 > development/9.4] 👷(CLDSRV-860) Monitor async await migration#6151
bert-e merged 13 commits intodevelopment/9.4from
w/9.4/feature/CLDSRV-860/monitor-async-await-migration

Conversation

@bert-e
Copy link
Copy Markdown
Contributor

@bert-e bert-e commented Apr 15, 2026

This pull request has been created automatically.
It is linked to its parent pull request #6088.

Do not edit this pull request directly.
If you need to amend/cancel the changeset on branch
w/9.4/feature/CLDSRV-860/monitor-async-await-migration, please follow this
procedure:

 git fetch
 git checkout w/9.4/feature/CLDSRV-860/monitor-async-await-migration
 # <amend or cancel the changeset by _adding_ new commits>
 git push origin w/9.4/feature/CLDSRV-860/monitor-async-await-migration

Please always comment pull request #6088 instead of this one.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.95%. Comparing base (313d7ea) to head (21bb00d).
⚠️ Report is 15 commits behind head on development/9.4.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph
see 2 files with indirect coverage changes

@@                 Coverage Diff                 @@
##           development/9.4    #6151      +/-   ##
===================================================
- Coverage            84.96%   84.95%   -0.02%     
===================================================
  Files                  207      207              
  Lines                13662    13662              
===================================================
- Hits                 11608    11606       -2     
- Misses                2054     2056       +2     
Flag Coverage Δ
file-ft-tests 68.73% <ø> (-0.07%) ⬇️
kmip-ft-tests 28.17% <ø> (ø)
mongo-v0-ft-tests 69.94% <ø> (+0.01%) ⬆️
mongo-v1-ft-tests 69.90% <ø> (-0.11%) ⬇️
multiple-backend 36.42% <ø> (ø)
sur-tests 36.37% <ø> (ø)
sur-tests-inflights 37.36% <ø> (-0.03%) ⬇️
unit 71.30% <ø> (ø)
utapi-v2-tests 34.68% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

tempDirs.forEach(dir => fs.rmSync(dir, { recursive: true, force: true }));
});

it('check-diff-async exits successfully when no JS files changed', () => {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test names using it() should start with "should" per project conventions. For example: it("should exit successfully when no JS files changed", ...)

— Claude Code

@claude
Copy link
Copy Markdown

claude bot commented Apr 15, 2026

  • Test names using it() should start with "should" (tests/unit/githubScripts/asyncMigrationScripts.js)
    - Rename all four test descriptions to start with "should" per project conventions

    Review by Claude Code

@bert-e bert-e closed this Apr 15, 2026
@bert-e bert-e merged commit 72a7568 into development/9.4 Apr 15, 2026
35 checks passed
@bert-e bert-e deleted the w/9.4/feature/CLDSRV-860/monitor-async-await-migration branch April 15, 2026 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants