CLDSRV-894: Report turn-around time for PutObject and UploadPart by dvasilas · Pull Request #6153 · scality/cloudserver

dvasilas · 2026-04-16T15:38:26Z

Turn-around time was initially left unreported for PutObject and UploadPart because these operations stream the request body to the storage backend as it arrives. For large objects, receiving and processing overlap, so the measured turn-around time only captures the tail-end confirmation latency rather than the full processing duration. We decided this was misleading and chose to report '-' instead.

However, testing against AWS shows that it does report turn-around time for these operations regardless of object size. This PR aligns our behavior with AWS.

bert-e · 2026-04-16T15:38:30Z

Hello dvasilas,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options

name	description	privileged	authored
`/after_pull_request`	Wait for the given pull request id to be merged before continuing with the current one.
`/bypass_author_approval`	Bypass the pull request author's approval	⭐
`/bypass_build_status`	Bypass the build and test status	⭐
`/bypass_commit_size`	Bypass the check on the size of the changeset `TBA`	⭐
`/bypass_incompatible_branch`	Bypass the check on the source branch prefix	⭐
`/bypass_jira_check`	Bypass the Jira issue check	⭐
`/bypass_peer_approval`	Bypass the pull request peers' approval	⭐
`/bypass_leader_approval`	Bypass the pull request leaders' approval	⭐
`/approve`	Instruct Bert-E that the author has approved the pull request.		✍️
`/create_pull_requests`	Allow the creation of integration pull requests.
`/create_integration_branches`	Allow the creation of integration branches.
`/no_octopus`	Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
`/unanimity`	Change review acceptance criteria from `one reviewer at least` to `all reviewers`
`/wait`	Instruct Bert-E not to run until further notice.

Available commands

name	description	privileged
`/help`	Print Bert-E's manual in the pull request.
`/status`	Print Bert-E's current status in the pull request `TBA`
`/clear`	Remove all comments from Bert-E from the history `TBA`
`/retry`	Re-start a fresh build `TBA`
`/build`	Re-start a fresh build `TBA`
`/force_reset`	Delete integration branches & pull requests, and restart merge process from the beginning.
`/reset`	Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

bert-e · 2026-04-16T15:38:36Z

Request integration branches

Waiting for integration branch creation to be requested by the user.

To request integration branches, please comment on this pull request with the following command:

/create_integration_branches

Alternatively, the /approve and /create_pull_requests commands will automatically
create the integration branches.

claude · 2026-04-16T15:40:49Z

LGTM

Review by Claude Code

claude · 2026-04-16T15:42:52Z

LGTM

Review by Claude Code

codecov · 2026-04-16T15:43:17Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.35%. Comparing base (46a99ae) to head (314ba8c).
⚠️ Report is 1 commits behind head on development/9.2.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Files with missing lines	Coverage Δ
lib/api/api.js	`90.16% <100.00%> (+0.24%)`	⬆️

... and 1 file with indirect coverage changes

@@                 Coverage Diff                 @@
##           development/9.2    #6153      +/-   ##
===================================================
+ Coverage            84.29%   84.35%   +0.06%     
===================================================
  Files                  204      204              
  Lines                13147    13153       +6     
===================================================
+ Hits                 11082    11095      +13     
+ Misses                2065     2058       -7

Flag	Coverage Δ
file-ft-tests	`67.67% <100.00%> (+0.02%)`	⬆️
kmip-ft-tests	`28.24% <83.33%> (+0.01%)`	⬆️
mongo-v0-ft-tests	`68.90% <100.00%> (+0.01%)`	⬆️
mongo-v1-ft-tests	`68.95% <100.00%> (+0.06%)`	⬆️
multiple-backend	`35.29% <83.33%> (+0.02%)`	⬆️
sur-tests	`36.60% <83.33%> (+0.02%)`	⬆️
sur-tests-inflights	`37.61% <83.33%> (-0.01%)`	⬇️
unit	`69.97% <100.00%> (+0.05%)`	⬆️
utapi-v2-tests	`34.53% <83.33%> (+0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

claude · 2026-04-16T16:35:03Z

LGTM

Review by Claude Code

claude · 2026-04-16T16:48:08Z

LGTM

Review by Claude Code

jonathan-gramain · 2026-04-16T19:15:26Z

+                    // For 0-byte uploads, downstream handlers do not consume
+                    // the request stream, so 'end' never fires. Set


Strange, sounds like a bug at first that the request stream is not consumed, do you happen to know if there's a good reason to be so?

I think it's an optimization:

cloudserver/lib/api/apiUtils/object/createAndStoreObject.js

Line 217 in 029b436

if (size === 0) {

Server access logs did not report turn-around time for PutObject and UploadPart while all other operations reported it correctly. AWS reports turn-around time for these operations.

claude · 2026-04-17T07:33:05Z

LGTM

Review by Claude Code

dvasilas · 2026-04-17T12:40:09Z

/approve

bert-e · 2026-04-17T12:40:21Z

Integration data created

I have created the integration data for the additional destination branches.

this pull request will merge bugfix/CLDSRV-894-turnaround-time-put-operations into
development/9.2
w/9.3/bugfix/CLDSRV-894-turnaround-time-put-operations will be merged into development/9.3
w/9.4/bugfix/CLDSRV-894-turnaround-time-put-operations will be merged into development/9.4

The following branches will NOT be impacted:

development/7.10
development/7.4
development/7.70
development/8.8
development/9.0
development/9.1

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

The following options are set: approve

bert-e · 2026-04-17T13:01:00Z

Build failed

The build for commit did not succeed in branch w/9.3/bugfix/CLDSRV-894-turnaround-time-put-operations

The following options are set: approve

bert-e · 2026-04-17T13:11:43Z

Build failed

The build for commit did not succeed in branch w/9.4/bugfix/CLDSRV-894-turnaround-time-put-operations

The following options are set: approve

bert-e · 2026-04-17T13:25:25Z

I have successfully merged the changeset of this pull request
into targetted development branches:

✔️ development/9.2
✔️ development/9.3
✔️ development/9.4

The following branches have NOT changed:

development/7.10
development/7.4
development/7.70
development/8.8
development/9.0
development/9.1

Please check the status of the associated issue CLDSRV-894.

Goodbye dvasilas.

The following options are set: approve

dvasilas force-pushed the bugfix/CLDSRV-894-turnaround-time-put-operations branch from feeb01e to 36ae90c Compare April 16, 2026 15:41

dvasilas changed the base branch from development/9.2 to improvement/CLDSRV-893-return-arn-for-assumed-role-in-access-logs April 16, 2026 15:41

BourgoisMickael approved these changes Apr 16, 2026

View reviewed changes

dvasilas force-pushed the bugfix/CLDSRV-894-turnaround-time-put-operations branch from 36ae90c to 638c986 Compare April 16, 2026 16:32

dvasilas requested a review from a team April 16, 2026 19:06

jonathan-gramain approved these changes Apr 16, 2026

View reviewed changes

CLDSRV-894: Report turn-around time for PutObject and UploadPart

314ba8c

Server access logs did not report turn-around time for PutObject and UploadPart while all other operations reported it correctly. AWS reports turn-around time for these operations.

dvasilas force-pushed the bugfix/CLDSRV-894-turnaround-time-put-operations branch from 61a3b01 to 314ba8c Compare April 17, 2026 07:31

Base automatically changed from improvement/CLDSRV-893-return-arn-for-assumed-role-in-access-logs to development/9.2 April 17, 2026 12:38

bert-e merged commit 314ba8c into development/9.2 Apr 17, 2026
30 checks passed

bert-e deleted the bugfix/CLDSRV-894-turnaround-time-put-operations branch April 17, 2026 13:25

		// For 0-byte uploads, downstream handlers do not consume
		// the request stream, so 'end' never fires. Set

Conversation

dvasilas commented Apr 16, 2026

Uh oh!

bert-e commented Apr 16, 2026

Hello dvasilas,

Uh oh!

bert-e commented Apr 16, 2026

Request integration branches

Uh oh!

claude bot commented Apr 16, 2026

Uh oh!

claude bot commented Apr 16, 2026

Uh oh!

codecov bot commented Apr 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

claude bot commented Apr 16, 2026

Uh oh!

claude bot commented Apr 16, 2026

Uh oh!

jonathan-gramain Apr 16, 2026

Choose a reason for hiding this comment

Uh oh!

dvasilas Apr 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

claude bot commented Apr 17, 2026

Uh oh!

dvasilas commented Apr 17, 2026

Uh oh!

bert-e commented Apr 17, 2026

Integration data created

Uh oh!

bert-e commented Apr 17, 2026

Build failed

Uh oh!

bert-e commented Apr 17, 2026

Build failed

Uh oh!

bert-e commented Apr 17, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov bot commented Apr 16, 2026 •

edited

Loading

dvasilas Apr 17, 2026 •

edited

Loading