CLDSRV-914: abort in-progress MPUs in mpuVersion test cleanup#6184
Conversation
|
LGTM |
The error-handling cases initiate multipart uploads that intentionally fail to complete, leaving an in-progress upload behind. bucketUtil.empty only removes object versions and delete markers, so the per-bucket mpuShadowBucket survived bucket deletion and lingered in shared metadata. On a consensus (RAFT) backend this leftover polluted the global bucket list and broke the routeMetadata "should retrieve list of buckets" test. Abort any in-progress uploads for each test bucket in afterEach before emptying and deleting them.
tcarmet
force-pushed
the
bugfix/CLDSRV-914-mpu-shadow-bucket-cleanup
branch
from
d0dc921 to
8a23ffe
Compare
tcarmet
changed the base branch from
bugfix/CLDSRV-911-incomplete-sdk-migration
to
development/9.3
Hello tcarmet,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
Request integration branchesWaiting for integration branch creation to be requested by the user. To request integration branches, please comment on this pull request with the following command: Alternatively, the |
|
LGTM |
❌ 2 Tests Failed:
View the top 1 failed test(s) by shortest run time
View the full list of 1 ❄️ flaky test(s)
To view more test analytics, go to the Test Analytics Dashboard |
Incorrect fix versionThe
Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:
Please check the |
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
| checkError(err, 'MethodNotAllowed', 405); | ||
| }); | ||
|
|
||
| putMPUVersion(s3, bucketName, objectName, vId) |
There was a problem hiding this comment.
putMPUVersion is not awaited here — the test will always pass regardless of the promise outcome because the try block completes before the promise settles. The checkError assertion in .catch() is never verified during the test run. Pre-existing, but since this code was reformatted, consider adding await.
— Claude Code
|
Request integration branchesWaiting for integration branch creation to be requested by the user. To request integration branches, please comment on this pull request with the following command: Alternatively, the |
|
/approve |
Integration data createdI have created the integration data for the additional destination branches.
The following branches will NOT be impacted:
You can set option The following options are set: approve |
Build failedThe build for commit did not succeed in branch w/9.4/bugfix/CLDSRV-914-mpu-shadow-bucket-cleanup The following options are set: approve |
In the queueThe changeset has received all authorizations and has been added to the The changeset will be merged in:
The following branches will NOT be impacted:
This pull request does not target the following hotfix branch(es) so they
There is no action required on your side. You will be notified here once IMPORTANT Please do not attempt to modify this pull request.
If you need this pull request to be removed from the queue, please contact a The following options are set: approve |
Queue build failedThe corresponding build for the queue failed:
Remove the pull request from the queue
|
|
I have successfully merged the changeset of this pull request
The following branches have NOT changed:
Please check the status of the associated issue CLDSRV-914. Goodbye tcarmet. |
5 participants
The mpuVersion functional test initiates multipart uploads that intentionally fail to complete (its error-handling cases), leaving in-progress uploads behind. The existing cleanup only removed object versions and delete markers, so the per-bucket MPU shadow bucket survived bucket deletion and lingered in shared metadata; on a consensus (RAFT) backend this leftover polluted the global bucket list and deterministically broke the metadata-routes "should retrieve list of buckets" test. This aborts any in-progress uploads for each test bucket before emptying and deleting them, so no shadow bucket is orphaned. The issue is pre-existing and not a 9.3 regression.