Skip to content

Improvement/misc improvement placeholder line height#1000

Merged
bert-e merged 6 commits intodevelopment/1.0from
improvement/misc-improvement-placeholder-line-height
Feb 10, 2026
Merged

Improvement/misc improvement placeholder line height#1000
bert-e merged 6 commits intodevelopment/1.0from
improvement/misc-improvement-placeholder-line-height

Conversation

@JeanMarcMilletScality
Copy link
Contributor

Misc Improvement

Placeholder

Placeholder can be too long/not useful. The prefix sometimes unnecessarily extends the placeholder (SearchInput case). Or the input is too small (compared to available place)

  • Input has a default prefix for placeholder. We don't want it for SearchInput and possibly others cases but we want it most of the times. Add a props that remove it if needed
  • Add size to InputList to be able to handle size. Sometimes placeholder is too long while there is a lot of room for input

Line-Height

Line height is too big for constrained height container (Table, Select options, etc).

  • Add a prop in text to allow the change of line-height.
    For now it is used for helper text but it could be used elsewhere. Create a Text wrapper specific to helper text
  • Change line-height for ConstrainedText on multiple lines

Ref: https://docs.google.com/document/d/1Mtv5SFpai_2FxN-jh00eZ6LShaUoUTZ4-rIDrX90Xnw/edit?tab=t.hvadtzdafoq5#heading=h.gfn68ibob54k

This prop will render a default icon where iconName and icon color are corresponding to the variant.
…y rendering with text content, title, default icon, and custom icon.

Add container for Icon in Banner component and remove css rules (moves them to container)
Add possibility to reduce line height in Text. Create a specific component for helper Text to have clear intent
Update form with helper text
…ut not for some usecases like SearchInput. Add a boolean prop to remove it when not needed

Use the new prop in searchInput
@bert-e
Copy link
Contributor

bert-e commented Feb 10, 2026

Hello jeanmarcmilletscality,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Feb 10, 2026

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

@JeanMarcMilletScality
Copy link
Contributor Author

/approve

@bert-e
Copy link
Contributor

bert-e commented Feb 10, 2026

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

The following options are set: approve

Copy link
Contributor

@MonPote MonPote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we probably want to make a PR for the formating too.
More than half of the change are formating noise 🥲

@bert-e
Copy link
Contributor

bert-e commented Feb 10, 2026

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/1.0

Please check the status of the associated issue None.

Goodbye jeanmarcmilletscality.

The following options are set: approve

@bert-e bert-e merged commit e2afb7d into development/1.0 Feb 10, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants