Skip to content

Improvement/accessibility icon#1005

Merged
bert-e merged 8 commits intodevelopment/1.0from
improvement/accessibility-icon
Feb 13, 2026
Merged

Improvement/accessibility icon#1005
bert-e merged 8 commits intodevelopment/1.0from
improvement/accessibility-icon

Conversation

@JeanMarcMilletScality
Copy link
Contributor

follow recommendations for accessibility for icon

  • Icon are decorative: they have aria-hidden: true by default, and are not visible for screenreaders
  • Only icon with meaning should be visible for screenreaders: Icon-only button, Iconhelp, statusIcon
  • IconHelp tooltip should be accessible by keyboard not only by mouse hover

Changes:

  • Icon does not have an aria-label by default anymore
  • Iconhelp is wrap in a button to be focusable, add esc key handling to dismiss tooltip, have a default aria label 'More information'. Should be change if possible when using it to me more meaningful
  • Change Button: icon only button will enforce tooltip if label is not provided, tooltip will serve as aria-label. why ? The tooltip should already convey the purpose of button: avoid adding a prop, most already have one)

Follow recommendation to keep icon decorative asdefault behaviour (hidden to screen readers)
Update IconHelp to be focusable
Fix some issue in component using Icon/IconHelp or icon-only Button
@bert-e
Copy link
Contributor

bert-e commented Feb 12, 2026

Hello jeanmarcmilletscality,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Feb 12, 2026

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

@JeanMarcMilletScality JeanMarcMilletScality force-pushed the improvement/accessibility-icon branch from 8e23851 to e9a289b Compare February 12, 2026 16:25
@JeanMarcMilletScality JeanMarcMilletScality force-pushed the improvement/accessibility-icon branch from e9a289b to 7bf1fea Compare February 12, 2026 16:36
@bert-e
Copy link
Contributor

bert-e commented Feb 12, 2026

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

@bert-e
Copy link
Contributor

bert-e commented Feb 13, 2026

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

@JeanMarcMilletScality
Copy link
Contributor Author

/approve

@bert-e
Copy link
Contributor

bert-e commented Feb 13, 2026

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ development/1.0

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Feb 13, 2026

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/1.0

Please check the status of the associated issue None.

Goodbye jeanmarcmilletscality.

@bert-e bert-e merged commit 14c41ca into development/1.0 Feb 13, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants