feature/valalint by damiengillesscality · Pull Request #1025 · scality/core-ui

damiengillesscality · 2026-03-04T15:45:40Z

Resolves https://scality.atlassian.net/browse/CUI-2 by implementing an EsLint rule plugin that check for capitalisation issues.
It can be used easily by configuring projects like this:

import valalint from '@scality/core-ui/eslint-plugin';

export default [
  {
    files: ['**/*.{js,jsx,ts,tsx}'],
    ignores: ['src/gen/**'],
    ...valalint.configs['flat/recommended'],
  },
];

The rule is also tested using the existing jest setup. I updated a few import in the test files that where still using CommonJs notation to be able to use type: module in package.json.

bert-e · 2026-03-04T15:45:44Z

Hello damiengillesscality,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options

name	description	privileged	authored
`/after_pull_request`	Wait for the given pull request id to be merged before continuing with the current one.
`/bypass_author_approval`	Bypass the pull request author's approval	⭐
`/bypass_build_status`	Bypass the build and test status	⭐
`/bypass_commit_size`	Bypass the check on the size of the changeset `TBA`	⭐
`/bypass_incompatible_branch`	Bypass the check on the source branch prefix	⭐
`/bypass_jira_check`	Bypass the Jira issue check	⭐
`/bypass_peer_approval`	Bypass the pull request peers' approval	⭐
`/bypass_leader_approval`	Bypass the pull request leaders' approval	⭐
`/approve`	Instruct Bert-E that the author has approved the pull request.		✍️
`/create_pull_requests`	Allow the creation of integration pull requests.
`/create_integration_branches`	Allow the creation of integration branches.
`/no_octopus`	Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
`/unanimity`	Change review acceptance criteria from `one reviewer at least` to `all reviewers`
`/wait`	Instruct Bert-E not to run until further notice.

Available commands

name	description	privileged
`/help`	Print Bert-E's manual in the pull request.
`/status`	Print Bert-E's current status in the pull request `TBA`
`/clear`	Remove all comments from Bert-E from the history `TBA`
`/retry`	Re-start a fresh build `TBA`
`/build`	Re-start a fresh build `TBA`
`/force_reset`	Delete integration branches & pull requests, and restart merge process from the beginning.
`/reset`	Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

bert-e · 2026-03-04T15:45:54Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

MonPote · 2026-03-04T18:20:19Z

@damiengillesscality I'm trying to use it in metalk8s.

I have this :

-> % npm run lint

> metalk8s-platform-ui@0.1.0 lint
> eslint .


Oops! Something went wrong! :(

ESLint: 10.0.2

Error [ERR_MODULE_NOT_FOUND]: Cannot find package '@typescript-eslint/parser' imported from /Users/patrickear/Scality/metalk8s/ui/node_modules/@scality/core-ui/src/lib/valalint/index.js
    at packageResolve (node:internal/modules/esm/resolve:873:9)
    at moduleResolve (node:internal/modules/esm/resolve:946:18)
    at defaultResolve (node:internal/modules/esm/resolve:1188:11)
    at ModuleLoader.defaultResolve (node:internal/modules/esm/loader:642:12)
    at #cachedDefaultResolve (node:internal/modules/esm/loader:591:25)
    at ModuleLoader.resolve (node:internal/modules/esm/loader:574:38)
    at ModuleLoader.getModuleJobForImport (node:internal/modules/esm/loader:236:38)
    at ModuleJob._link (node:internal/modules/esm/module_job:130:49)
patrickear@Patricks-MacBook-Pro [19:01:00] [~/Scality/metalk8s/ui] [imp

I guess we need to have @typescript-eslint/parser in our devDeps. Do you think it's necessary to have it in core-ui peerDeps ?

bert-e · 2026-03-05T12:55:26Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

damiengillesscality · 2026-03-05T12:59:44Z

I think the solution is to move @typescript-eslint/parser from devDeps to deps. This wont change our front end build size and core ui will be installed with the tools to use the linting rules. I've made a commit to do that let me know if it is fine for you.

@damiengillesscality I'm trying to use it in metalk8s.

I have this :

-> % npm run lint

> metalk8s-platform-ui@0.1.0 lint
> eslint .


Oops! Something went wrong! :(

ESLint: 10.0.2

Error [ERR_MODULE_NOT_FOUND]: Cannot find package '@typescript-eslint/parser' imported from /Users/patrickear/Scality/metalk8s/ui/node_modules/@scality/core-ui/src/lib/valalint/index.js
    at packageResolve (node:internal/modules/esm/resolve:873:9)
    at moduleResolve (node:internal/modules/esm/resolve:946:18)
    at defaultResolve (node:internal/modules/esm/resolve:1188:11)
    at ModuleLoader.defaultResolve (node:internal/modules/esm/loader:642:12)
    at #cachedDefaultResolve (node:internal/modules/esm/loader:591:25)
    at ModuleLoader.resolve (node:internal/modules/esm/loader:574:38)
    at ModuleLoader.getModuleJobForImport (node:internal/modules/esm/loader:236:38)
    at ModuleJob._link (node:internal/modules/esm/module_job:130:49)
patrickear@Patricks-MacBook-Pro [19:01:00] [~/Scality/metalk8s/ui] [imp

I guess we need to have @typescript-eslint/parser in our devDeps. Do you think it's necessary to have it in core-ui peerDeps ?

MonPote · 2026-03-05T14:29:12Z

I think the solution is to move @typescript-eslint/parser from devDeps to deps. This wont change our front end build size and core ui will be installed with the tools to use the linting rules. I've made a commit to do that let me know if it is fine for you.
@damiengillesscality I'm trying to use it in metalk8s.
I have this :
-> % npm run lint

> metalk8s-platform-ui@0.1.0 lint
> eslint .


Oops! Something went wrong! :(

ESLint: 10.0.2

Error [ERR_MODULE_NOT_FOUND]: Cannot find package '@typescript-eslint/parser' imported from /Users/patrickear/Scality/metalk8s/ui/node_modules/@scality/core-ui/src/lib/valalint/index.js
    at packageResolve (node:internal/modules/esm/resolve:873:9)
    at moduleResolve (node:internal/modules/esm/resolve:946:18)
    at defaultResolve (node:internal/modules/esm/resolve:1188:11)
    at ModuleLoader.defaultResolve (node:internal/modules/esm/loader:642:12)
    at #cachedDefaultResolve (node:internal/modules/esm/loader:591:25)
    at ModuleLoader.resolve (node:internal/modules/esm/loader:574:38)
    at ModuleLoader.getModuleJobForImport (node:internal/modules/esm/loader:236:38)
    at ModuleJob._link (node:internal/modules/esm/module_job:130:49)
patrickear@Patricks-MacBook-Pro [19:01:00] [~/Scality/metalk8s/ui] [imp
I guess we need to have @typescript-eslint/parser in our devDeps. Do you think it's necessary to have it in core-ui peerDeps ?

Yes I was thinking about that too, i was not sure about the impact to our UIs.
It works now ^^

MonPote · 2026-03-05T14:32:02Z

@damiengillesscality Can you check why it show a warning for this case ?

      <Text variant="Smaller" style={{ fontStyle: 'italic', color: '#666' }}>
        No nodes found {quantileName === 'Q90' ? 'above' : 'below'} threshold
      </Text>

damiengillesscality · 2026-03-05T16:18:19Z

<Text variant="Smaller" style={{ fontStyle: 'italic', color: '#666' }}>
        No nodes found {quantileName === 'Q90' ? 'above' : 'below'} threshold
      </Text>

Their was a bug, this created multiple jsx text element and it treated them each as sentence. So it expected a capitalized letter on threshold. this is fixed.

MonPote

LGTM

damiengillesscality · 2026-03-05T16:38:14Z

/approve

bert-e · 2026-03-05T16:38:23Z

I have successfully merged the changeset of this pull request
into targetted development branches:

✔️ development/1.0

Please check the status of the associated issue CUI-2.

Goodbye damiengillesscality.

The following options are set: approve

damiengillesscality mentioned this pull request Mar 4, 2026

feature/valalint #1024

Closed

feature/valalint

82da530

damiengillesscality force-pushed the feature/CUI-2-valalint branch from 3b36515 to 82da530 Compare March 4, 2026 15:58

Move @typescript-eslint/parser to deps

2a92615

damiengillesscality requested a review from MonPote March 5, 2026 13:00

Fix multi jsxtext case in technical sentence rule

a528e0a

MonPote approved these changes Mar 5, 2026

View reviewed changes

bert-e merged commit a528e0a into development/1.0 Mar 5, 2026
4 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feature/valalint#1025

feature/valalint#1025
bert-e merged 3 commits intodevelopment/1.0from
feature/CUI-2-valalint

damiengillesscality commented Mar 4, 2026 •

edited

Loading

Uh oh!

bert-e commented Mar 4, 2026

Uh oh!

bert-e commented Mar 4, 2026

Uh oh!

MonPote commented Mar 4, 2026

Uh oh!

bert-e commented Mar 5, 2026

Uh oh!

damiengillesscality commented Mar 5, 2026

Uh oh!

MonPote commented Mar 5, 2026

Uh oh!

MonPote commented Mar 5, 2026

Uh oh!

damiengillesscality commented Mar 5, 2026

Uh oh!

MonPote left a comment

Uh oh!

damiengillesscality commented Mar 5, 2026

Uh oh!

bert-e commented Mar 5, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

damiengillesscality commented Mar 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bert-e commented Mar 4, 2026

Hello damiengillesscality,

Uh oh!

bert-e commented Mar 4, 2026

Waiting for approval

Uh oh!

MonPote commented Mar 4, 2026

Uh oh!

bert-e commented Mar 5, 2026

Waiting for approval

Uh oh!

damiengillesscality commented Mar 5, 2026

Uh oh!

MonPote commented Mar 5, 2026

Uh oh!

MonPote commented Mar 5, 2026

Uh oh!

damiengillesscality commented Mar 5, 2026

Uh oh!

MonPote left a comment

Choose a reason for hiding this comment

Uh oh!

damiengillesscality commented Mar 5, 2026

Uh oh!

bert-e commented Mar 5, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

damiengillesscality commented Mar 4, 2026 •

edited

Loading