Skip to content

feat: add displayPreset prop to Barchart with modern style#1097

Merged
bert-e merged 3 commits intodevelopment/1.0from
improvement/barchart-modern-display-preset
Apr 30, 2026
Merged

feat: add displayPreset prop to Barchart with modern style#1097
bert-e merged 3 commits intodevelopment/1.0from
improvement/barchart-modern-display-preset

Conversation

@JeanMarcMilletScality
Copy link
Copy Markdown
Contributor

@JeanMarcMilletScality JeanMarcMilletScality commented Apr 29, 2026

Summary

Mirrors the LineTimeSeries displayPreset pattern: a 'modern' preset applies transparent background, horizontal grid lines synced to ticks, and removes axis/tick lines. A 'default' preset preserves existing behaviour. Individual options can be overridden via displayOptions.

Also remove tick lines on Y axis for Barchart and Line Chart

Design

https://potential-adventure-qjkz9qj.pages.github.io/branches/exploration-CUI-12-modal-width-exploration/?path=/story/templates-artesca-overview--with-veeam

image

Result

image

Mirrors the LineTimeSeries displayPreset pattern: a 'modern' preset
applies transparent background, horizontal grid lines synced to ticks,
and removes axis/tick lines. A 'default' preset preserves existing
behaviour. Individual options can be overridden via displayOptions.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Apr 29, 2026

Hello jeanmarcmilletscality,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Apr 29, 2026

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

JeanMarcMilletScality and others added 2 commits April 29, 2026 12:04
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Mirrors the Barchart behaviour: the modern preset now hides Y-axis tick
marks. Exposed as a displayOptions override so callers can toggle it
independently of the preset.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Apr 29, 2026

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

@JeanMarcMilletScality JeanMarcMilletScality marked this pull request as ready for review April 29, 2026 16:52
Copy link
Copy Markdown
Contributor

@ChengYanJin ChengYanJin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JeanMarcMilletScality
Copy link
Copy Markdown
Contributor Author

/approve

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Apr 30, 2026

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ development/1.0

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Apr 30, 2026

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/1.0

Please check the status of the associated issue None.

Goodbye jeanmarcmilletscality.

@bert-e bert-e merged commit 921f636 into development/1.0 Apr 30, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants