Improvement/c UI 16 inline input rework#1109
Conversation
Hello jeanmarcmilletscality,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
Peer approvals must include at least 1 approval from the following list: |
7a6e2bb to
6f23971
Compare
- Re-introduce useToast on commit's onError so failures surface to the user when no confirmation modal is provided (regression vs the old component behaviour). - Align submit's validation source with the visible state by checking validationError (derived from pendingValue) instead of re-running check() on the trimmed value, so a visibly-valid input is never silently rejected on Enter. - Guard onBlur with !isLoading to prevent a double mutation when the input blurs after a successful Enter-triggered commit. - Guard handleEditStart against isModalOpen so clicking the trigger while the confirmation modal is open no longer opens the editor on top of the modal.
- Move pendingValue initialization out of the focus useEffect into handleEditStart so that an external defaultValue update (e.g. a polled query refresh) no longer silently clobbers the user's in-progress typing or re-fires focus/select. - Switch the trigger to role="button" + aria-disabled/aria-busy instead of data-disabled so assistive technology accurately announces the loading and modal-open states. CSS hook updated to the aria attribute.
|
/approve |
In the queueThe changeset has received all authorizations and has been added to the The changeset will be merged in:
There is no action required on your side. You will be notified here once IMPORTANT Please do not attempt to modify this pull request.
If you need this pull request to be removed from the queue, please contact a The following options are set: approve |
|
I have successfully merged the changeset of this pull request
Please check the status of the associated issue CUI-16. Goodbye jeanmarcmilletscality. |
Summary
Rework the InlineInput to match the new InstanceName button
Result