renovate: annotate Makefile tool versions#18
Open
vdaviot wants to merge 1 commit into
Open
Conversation
Activates the shared platform-renovate preset's `customManagers:makefileVersions` for the kubebuilder scaffold's tool pins. Annotated: - `OPERATOR_SDK_VERSION` → operator-framework/operator-sdk - `CERT_MANAGER_VERSION` → cert-manager/cert-manager - `KUSTOMIZE_VERSION` → kubernetes-sigs/kustomize (with `extractVersion=^kustomize/(?<version>.*)$` because release tags are prefixed with `kustomize/`) - `CONTROLLER_TOOLS_VERSION` → kubernetes-sigs/controller-tools - `GOLANGCI_LINT_VERSION` → golangci/golangci-lint Also refactor the hardcoded `opm` URL into a tracked `OPM_VERSION` variable so it can be managed alongside the others. The downloaded URL is unchanged at runtime (`v1.55.0` is now `$(OPM_VERSION)`). Once `scality/platform-renovate#3` lands, all six tools join the `operator-tooling` group with label `deps/operator-tooling` (`golangci-lint` joins the `golangci-lint` group with `deps/lint`). Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Annotates the kubebuilder-scaffolded tool pins in
Makefileso the new sharedplatform-renovatepreset'scustomManagers:makefileVersionscan manage them. Tracks one of the four follow-ups listed inscality/platform-renovate#3(the in-flight PR comment).Annotations added
OPERATOR_SDK_VERSION→operator-framework/operator-sdkGitHub releasesCERT_MANAGER_VERSION→cert-manager/cert-managerGitHub releasesKUSTOMIZE_VERSION→kubernetes-sigs/kustomizeGitHub releases. UsesextractVersion=^kustomize/(?<version>.*)$because the upstream releases are tagged with akustomize/prefix (the kustomize repo is a multi-tool monorepo).CONTROLLER_TOOLS_VERSION→kubernetes-sigs/controller-toolsGitHub releasesGOLANGCI_LINT_VERSION→golangci/golangci-lintGitHub releasesRefactor:
opmURL →OPM_VERSIONThe previous
opmrule hadv1.55.0hardcoded inside acurlURL, which Renovate's regex managers can't see. Refactored to a tracked variable:The downloaded URL is identical at runtime; only the source-of-truth changes.
Merge order
Depends on
scality/platform-renovate#3(and indirectly onscality/crl-operator#15which wires this repo to the shared preset). The annotations are inert until the new preset'scustomManagers:makefileVersionsis active.Test plan
make opm(or any rule that exercisesOPM) still downloads the same v1.55.0 binary.operator-tooling/golangci-lintgroups on the Dependency Dashboard.