Improvement/hd 4608 fix release workflow#1160
Conversation
Hello benzekrimaha,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
Request integration branchesWaiting for integration branch creation to be requested by the user. To request integration branches, please comment on this pull request with the following command: Alternatively, the |
5507717 to
8cf95ec
Compare
| contents: read | ||
| environment: npmjs | ||
| steps: | ||
| - uses: actions/checkout@v4 |
There was a problem hiding this comment.
can update checkout to v6 and setup node to v6 if you want
| publish-npm: | ||
| runs-on: ubuntu-latest | ||
| needs: check | ||
| if: github.ref == 'refs/heads/main' |
There was a problem hiding this comment.
whats that, If the branch isn't main, publish npm will not be run ? Doesn't it means that when releasing from developemnt/x, it will be blocked since its not main 🤔
There was a problem hiding this comment.
| if: github.ref == 'refs/heads/main' | |
| if: startsWith(github.ref, 'refs/heads/development/') |
maeldonn
left a comment
There was a problem hiding this comment.
Same review as Sylvain. If we only run the workflow on development/ branches, we can get rid of the extra checks.
on:
workflow_dispatch:
inputs:
tag:
description: 'Tag to be released'
required: true
branches:
- 'development/**'
| publish-npm: | ||
| runs-on: ubuntu-latest | ||
| needs: check | ||
| if: github.ref == 'refs/heads/main' |
There was a problem hiding this comment.
| if: github.ref == 'refs/heads/main' | |
| if: startsWith(github.ref, 'refs/heads/development/') |
This commit updates the release workflow to use npm trusted publishing (OIDC) instead of NPM_TOKEN. it also adds required job permissions for npm OIDC auth: id-token: write and contents: read. Npm publish was kept explicit with --access public. package.json repository metadata was updated to npm-recommended object format. Issue:HD-4608
Issue: HD-4608
103319b to
194716c
Compare
|
/approve |
Integration data createdI have created the integration data for the additional destination branches.
The following branches will NOT be impacted:
You can set option The following options are set: approve |
|
I have successfully merged the changeset of this pull request
The following branches have NOT changed:
Please check the status of the associated issue HD-4608. Goodbye benzekrimaha. The following options are set: approve |
Issue: HD-4608