Skip to content

Improvement/hd 4608 fix release workflow#1160

Merged
bert-e merged 2 commits intodevelopment/1.3from
improvement/HD-4608-fix-release-workflow
Apr 13, 2026
Merged

Improvement/hd 4608 fix release workflow#1160
bert-e merged 2 commits intodevelopment/1.3from
improvement/HD-4608-fix-release-workflow

Conversation

@benzekrimaha
Copy link
Copy Markdown
Contributor

@benzekrimaha benzekrimaha commented Apr 10, 2026

Issue: HD-4608

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Apr 10, 2026

Hello benzekrimaha,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Apr 10, 2026

Request integration branches

Waiting for integration branch creation to be requested by the user.

To request integration branches, please comment on this pull request with the following command:

/create_integration_branches

Alternatively, the /approve and /create_pull_requests commands will automatically
create the integration branches.

@benzekrimaha benzekrimaha force-pushed the improvement/HD-4608-fix-release-workflow branch 3 times, most recently from 5507717 to 8cf95ec Compare April 10, 2026 16:16
@benzekrimaha benzekrimaha marked this pull request as ready for review April 10, 2026 16:17
@benzekrimaha benzekrimaha requested review from a team, delthas and maeldonn April 10, 2026 16:17
Comment thread .github/workflows/release.yaml Outdated
contents: read
environment: npmjs
steps:
- uses: actions/checkout@v4
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can update checkout to v6 and setup node to v6 if you want

Comment thread .github/workflows/release.yaml Outdated
publish-npm:
runs-on: ubuntu-latest
needs: check
if: github.ref == 'refs/heads/main'
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whats that, If the branch isn't main, publish npm will not be run ? Doesn't it means that when releasing from developemnt/x, it will be blocked since its not main 🤔

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if: github.ref == 'refs/heads/main'
if: startsWith(github.ref, 'refs/heads/development/')

Copy link
Copy Markdown

@maeldonn maeldonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same review as Sylvain. If we only run the workflow on development/ branches, we can get rid of the extra checks.

on:
    workflow_dispatch:
      inputs:
        tag:
          description: 'Tag to be released'
          required: true
      branches:
        - 'development/**'

Comment thread .github/workflows/release.yaml Outdated
publish-npm:
runs-on: ubuntu-latest
needs: check
if: github.ref == 'refs/heads/main'
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if: github.ref == 'refs/heads/main'
if: startsWith(github.ref, 'refs/heads/development/')

Comment thread .github/workflows/release.yaml Outdated
Comment thread .github/workflows/release.yaml Outdated
This commit updates the release workflow to use npm
trusted publishing (OIDC) instead of NPM_TOKEN.
it also adds required job permissions for npm OIDC auth:
id-token: write and contents: read.
Npm publish was kept explicit with --access public.
package.json repository metadata was updated to npm-recommended object format.

Issue:HD-4608
@benzekrimaha benzekrimaha force-pushed the improvement/HD-4608-fix-release-workflow branch from 103319b to 194716c Compare April 13, 2026 10:01
@benzekrimaha
Copy link
Copy Markdown
Contributor Author

/approve

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Apr 13, 2026

Integration data created

I have created the integration data for the additional destination branches.

The following branches will NOT be impacted:

  • development/1.0
  • development/1.1
  • development/1.2

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

The following options are set: approve

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Apr 13, 2026

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/1.3

  • ✔️ development/1

The following branches have NOT changed:

  • development/1.0
  • development/1.1
  • development/1.2

Please check the status of the associated issue HD-4608.

Goodbye benzekrimaha.

The following options are set: approve

@bert-e bert-e merged commit 194716c into development/1.3 Apr 13, 2026
1 check passed
@bert-e bert-e deleted the improvement/HD-4608-fix-release-workflow branch April 13, 2026 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants