Skip to content

Export commonjs module#908

Merged
bert-e merged 4 commits intodevelopment/1.2from
improvement/HD-4097
Feb 17, 2025
Merged

Export commonjs module#908
bert-e merged 4 commits intodevelopment/1.2from
improvement/HD-4097

Conversation

@francoisferrand
Copy link
Copy Markdown
Contributor

  • Export module as commonjs
  • Migrate index.ts to typescript

Issue: HD-4097

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Feb 17, 2025

Hello francoisferrand,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Feb 17, 2025

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

@francoisferrand
Copy link
Copy Markdown
Contributor Author

/create_integration_branches

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Feb 17, 2025

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

The following options are set: create_integration_branches

This is the format we generally use, and directly supported by typescript.

Issue: HD-4097
`index.js` is now generated form `index.ts`, and the javascript files
are stored in the `src/` folder.

Issue: HD-4097
Issue: HD-4097
@francoisferrand francoisferrand changed the base branch from development/1 to development/1.2 February 17, 2025 09:32
@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Feb 17, 2025

Integration data created

I have created the integration data for the additional destination branches.

  • this pull request will merge improvement/HD-4097 into
    development/1.2
  • w/1/improvement/HD-4097 will be merged into development/1

The following branches will NOT be impacted:

  • development/1.0
  • development/1.1

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

The following options are set: create_integration_branches

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Feb 17, 2025

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

The following options are set: create_integration_branches

Comment thread src/hdcontroller.js
}
}, {}, payload);
}, err => {
}, (err) => {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be simplified with a simple call to the callback, as there is no logic here (same for other places + on the TS file of course)

Comment thread package.json
Issue: HD-4097
@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Feb 17, 2025

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

The following options are set: create_integration_branches

@scality scality deleted a comment from bert-e Feb 17, 2025
@francoisferrand
Copy link
Copy Markdown
Contributor Author

/approve

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Feb 17, 2025

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ development/1.2

  • ✔️ development/1

The following branches will NOT be impacted:

  • development/1.0
  • development/1.1

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve, create_integration_branches

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Feb 17, 2025

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/1.2

  • ✔️ development/1

The following branches have NOT changed:

  • development/1.0
  • development/1.1

Please check the status of the associated issue HD-4097.

Goodbye francoisferrand.

@bert-e bert-e merged commit 536f29c into development/1.2 Feb 17, 2025
@bert-e bert-e deleted the improvement/HD-4097 branch February 17, 2025 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants