Skip to content

Conversation

@tcarmet
Copy link
Contributor

@tcarmet tcarmet commented Jan 5, 2026

With the way the CI is set, executing the ft tests after the unit tests erase the coverage knowledge of the unit tests. Now keeping them in separate folders so we can upload the full picture to codecov.

@codecov
Copy link

codecov bot commented Jan 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 43.65%. Comparing base (5bcb71a) to head (469196c).
⚠️ Report is 1 commits behind head on development/1.16.

Additional details and impacted files
@@                  Coverage Diff                  @@
##           development/1.16     #361       +/-   ##
=====================================================
+ Coverage             15.65%   43.65%   +27.99%     
=====================================================
  Files                    82       82               
  Lines                  5718     5718               
  Branches               1208     1208               
=====================================================
+ Hits                    895     2496     +1601     
+ Misses                 4754     3177     -1577     
+ Partials                 69       45       -24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tcarmet tcarmet marked this pull request as ready for review January 5, 2026 20:18
@tcarmet tcarmet force-pushed the feature/S3UTILS-211-configurable-replication-status branch 2 times, most recently from a3f2ff1 to 79a27d3 Compare January 5, 2026 22:44
@tcarmet tcarmet changed the base branch from feature/S3UTILS-211-configurable-replication-status to development/1.16 January 6, 2026 18:05
@bert-e
Copy link
Contributor

bert-e commented Jan 6, 2026

Hello tcarmet,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@tcarmet tcarmet force-pushed the feature/S3UTILS-211-split-cov-directories branch from b1efed5 to 469196c Compare January 6, 2026 18:05
@tcarmet tcarmet requested a review from a team January 6, 2026 18:07
@tcarmet
Copy link
Contributor Author

tcarmet commented Jan 6, 2026

/bypass_jira_check

@bert-e
Copy link
Contributor

bert-e commented Jan 6, 2026

Request integration branches

Waiting for integration branch creation to be requested by the user.

To request integration branches, please comment on this pull request with the following command:

/create_integration_branches

Alternatively, the /approve and /create_pull_requests commands will automatically
create the integration branches.

The following options are set: bypass_jira_check

@tcarmet
Copy link
Contributor Author

tcarmet commented Jan 6, 2026

/create_integration_branches

@scality scality deleted a comment from bert-e Jan 6, 2026
@bert-e
Copy link
Contributor

bert-e commented Jan 6, 2026

Integration data created

I have created the integration data for the additional destination branches.

The following branches will NOT be impacted:

  • development/1.13
  • development/1.14
  • development/1.15
  • development/1.4

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

The following options are set: bypass_jira_check, create_integration_branches

@bert-e
Copy link
Contributor

bert-e commented Jan 6, 2026

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

The following options are set: bypass_jira_check, create_integration_branches

@tcarmet
Copy link
Contributor Author

tcarmet commented Jan 6, 2026

/approve

@bert-e
Copy link
Contributor

bert-e commented Jan 6, 2026

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ development/1.16

  • ✔️ development/1

The following branches will NOT be impacted:

  • development/1.13
  • development/1.14
  • development/1.15
  • development/1.4

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: bypass_jira_check, approve, create_integration_branches

@bert-e
Copy link
Contributor

bert-e commented Jan 6, 2026

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/1.16

  • ✔️ development/1

The following branches have NOT changed:

  • development/1.13
  • development/1.14
  • development/1.15
  • development/1.4

Please check the status of the associated issue S3UTILS-211.

Goodbye tcarmet.

@bert-e bert-e merged commit 469196c into development/1.16 Jan 6, 2026
16 checks passed
@bert-e bert-e deleted the feature/S3UTILS-211-split-cov-directories branch January 6, 2026 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants