-
Notifications
You must be signed in to change notification settings - Fork 2
S3UTILS-211: split coverage directories #361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
S3UTILS-211: split coverage directories #361
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## development/1.16 #361 +/- ##
=====================================================
+ Coverage 15.65% 43.65% +27.99%
=====================================================
Files 82 82
Lines 5718 5718
Branches 1208 1208
=====================================================
+ Hits 895 2496 +1601
+ Misses 4754 3177 -1577
+ Partials 69 45 -24 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
a3f2ff1 to
79a27d3
Compare
Hello tcarmet,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
b1efed5 to
469196c
Compare
|
/bypass_jira_check |
Request integration branchesWaiting for integration branch creation to be requested by the user. To request integration branches, please comment on this pull request with the following command: Alternatively, the The following options are set: bypass_jira_check |
|
/create_integration_branches |
Integration data createdI have created the integration data for the additional destination branches.
The following branches will NOT be impacted:
You can set option The following options are set: bypass_jira_check, create_integration_branches |
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
The following options are set: bypass_jira_check, create_integration_branches |
|
/approve |
In the queueThe changeset has received all authorizations and has been added to the The changeset will be merged in:
The following branches will NOT be impacted:
There is no action required on your side. You will be notified here once IMPORTANT Please do not attempt to modify this pull request.
If you need this pull request to be removed from the queue, please contact a The following options are set: bypass_jira_check, approve, create_integration_branches |
|
I have successfully merged the changeset of this pull request
The following branches have NOT changed:
Please check the status of the associated issue S3UTILS-211. Goodbye tcarmet. |
With the way the CI is set, executing the ft tests after the unit tests erase the coverage knowledge of the unit tests. Now keeping them in separate folders so we can upload the full picture to codecov.