Improve unit testing for ISV assistant component #842

ziyang-lin-404 · 2025-04-16T13:10:12Z

No description provided.

…s for improved readability. Update mocks and assertions for IAM user and account selection, ensuring proper validation and error handling for duplicate entries.

…modal visibility, Continue button state validation, and navigation logic for multiple buckets. Remove deprecated test cases for improved clarity.

…onents

bert-e · 2025-04-16T13:10:15Z

Hello ziyang-lin-404,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options

name	description	privileged	authored
`/after_pull_request`	Wait for the given pull request id to be merged before continuing with the current one.
`/bypass_author_approval`	Bypass the pull request author's approval	⭐
`/bypass_build_status`	Bypass the build and test status	⭐
`/bypass_commit_size`	Bypass the check on the size of the changeset `TBA`	⭐
`/bypass_incompatible_branch`	Bypass the check on the source branch prefix	⭐
`/bypass_jira_check`	Bypass the Jira issue check	⭐
`/bypass_peer_approval`	Bypass the pull request peers' approval	⭐
`/bypass_leader_approval`	Bypass the pull request leaders' approval	⭐
`/approve`	Instruct Bert-E that the author has approved the pull request.		✍️
`/create_pull_requests`	Allow the creation of integration pull requests.
`/create_integration_branches`	Allow the creation of integration branches.
`/no_octopus`	Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
`/unanimity`	Change review acceptance criteria from `one reviewer at least` to `all reviewers`
`/wait`	Instruct Bert-E not to run until further notice.

Available commands

name	description	privileged
`/help`	Print Bert-E's manual in the pull request.
`/status`	Print Bert-E's current status in the pull request `TBA`
`/clear`	Remove all comments from Bert-E from the history `TBA`
`/retry`	Re-start a fresh build `TBA`
`/build`	Re-start a fresh build `TBA`
`/force_reset`	Delete integration branches & pull requests, and restart merge process from the beginning.
`/reset`	Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

bert-e · 2025-04-16T13:10:21Z

Request integration branches

Waiting for integration branch creation to be requested by the user.

To request integration branches, please comment on this pull request with the following command:

/create_integration_branches

Alternatively, the /approve and /create_pull_requests commands will automatically
create the integration branches.

…roper asynchronous handling in the test case.

JBWatenbergScality · 2025-05-05T08:29:34Z

/bypass_author_approval

bert-e · 2025-05-05T08:29:39Z

Request integration branches

Waiting for integration branch creation to be requested by the user.

To request integration branches, please comment on this pull request with the following command:

/create_integration_branches

Alternatively, the /approve and /create_pull_requests commands will automatically
create the integration branches.

The following options are set: bypass_author_approval

JBWatenbergScality · 2025-05-05T08:29:44Z

/create_integration_branches

bert-e · 2025-05-05T08:29:53Z

Integration data created

I have created the integration data for the additional destination branches.

this pull request will merge improvement/ARTESCA-14731-assistant-unit-tests into
development/3.1
w/3.2/improvement/ARTESCA-14731-assistant-unit-tests will be merged into development/3.2

The following branches will NOT be impacted:

development/1.4
development/1.5
development/1.6
development/2.0
development/2.1
development/2.2
development/3.0

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

The following options are set: bypass_author_approval, create_integration_branches

bert-e · 2025-05-05T08:29:59Z

History mismatch

Merge commit #e1d56a4fe829e85fe3635fcc25c812ee729bab64 on the integration branch
w/3.2/improvement/ARTESCA-14731-assistant-unit-tests is merging a branch which is neither the current
branch improvement/ARTESCA-14731-assistant-unit-tests nor the development branch
development/3.2.

It is likely due to a rebase of the branch improvement/ARTESCA-14731-assistant-unit-tests and the
merge is not possible until all related w/* branches are deleted or updated.

Please use the reset command to have me reinitialize these branches.

The following options are set: bypass_author_approval, create_integration_branches

JBWatenbergScality · 2025-05-13T07:49:22Z

/reset

bert-e · 2025-05-13T07:49:32Z

Reset complete

I have successfully deleted this pull request's integration branches.

The following options are set: bypass_author_approval, create_integration_branches

bert-e · 2025-05-13T07:49:40Z

Integration data created

I have created the integration data for the additional destination branches.

this pull request will merge improvement/ARTESCA-14731-assistant-unit-tests into
development/3.1
w/3.2/improvement/ARTESCA-14731-assistant-unit-tests will be merged into development/3.2

The following branches will NOT be impacted:

development/1.4
development/1.5
development/1.6
development/2.0
development/2.1
development/2.2
development/3.0

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

The following options are set: bypass_author_approval, create_integration_branches

bert-e · 2025-05-13T07:52:59Z

Build failed

The build for commit did not succeed in branch w/3.2/improvement/ARTESCA-14731-assistant-unit-tests

The following options are set: bypass_author_approval, create_integration_branches

ziyang-lin-404 · 2025-06-30T13:56:45Z

/status

bert-e · 2025-06-30T13:56:49Z

Status

Status report is not available.

The following options are set: bypass_author_approval, create_integration_branches

bert-e · 2025-06-30T13:57:00Z

Integration data created

I have created the integration data for the additional destination branches.

this pull request will merge improvement/ARTESCA-14731-assistant-unit-tests into
development/3.1
w/3.2/improvement/ARTESCA-14731-assistant-unit-tests will be merged into development/3.2
w/4.0/improvement/ARTESCA-14731-assistant-unit-tests will be merged into development/4.0
w/4.1/improvement/ARTESCA-14731-assistant-unit-tests will be merged into development/4.1

The following branches will NOT be impacted:

development/1.4
development/1.5
development/1.6
development/2.0
development/2.1
development/2.2
development/3.0

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

The following options are set: bypass_author_approval, create_integration_branches

bert-e · 2025-06-30T14:00:24Z

Build failed

The build for commit did not succeed in branch w/3.2/improvement/ARTESCA-14731-assistant-unit-tests

The following options are set: bypass_author_approval, create_integration_branches

bert-e · 2025-06-30T14:09:05Z

Build failed

The build for commit did not succeed in branch w/3.2/improvement/ARTESCA-14731-assistant-unit-tests

The following options are set: bypass_author_approval, create_integration_branches

bert-e · 2025-06-30T14:21:07Z

Build failed

The build for commit did not succeed in branch w/4.1/improvement/ARTESCA-14731-assistant-unit-tests

The following options are set: bypass_author_approval, create_integration_branches

ziyang-lin-404 · 2025-06-30T14:31:43Z

/status

bert-e · 2025-06-30T14:31:48Z

Status

Status report is not available.

The following options are set: bypass_author_approval, create_integration_branches

bert-e · 2025-06-30T14:31:56Z

Build failed

The build for commit did not succeed in branch w/4.1/improvement/ARTESCA-14731-assistant-unit-tests

The following options are set: bypass_author_approval, create_integration_branches

ziyang-lin-404 · 2025-06-30T15:25:06Z

/status

bert-e · 2025-06-30T15:25:10Z

Status

Status report is not available.

The following options are set: bypass_author_approval, create_integration_branches

bert-e · 2025-06-30T15:27:33Z

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

✔️ development/3.1
✔️ development/3.2
✔️ development/4.0
✔️ development/4.1

The following branches will NOT be impacted:

development/1.4
development/1.5
development/1.6
development/2.0
development/2.1
development/2.2
development/3.0

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

Any commit you add on the source branch will trigger a new cycle after the
current queue is merged.
Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: bypass_author_approval, create_integration_branches

bert-e · 2025-06-30T15:30:48Z

I have successfully merged the changeset of this pull request
into targetted development branches:

✔️ development/3.1
✔️ development/3.2
✔️ development/4.0
✔️ development/4.1

The following branches have NOT changed:

development/1.4
development/1.5
development/1.6
development/2.0
development/2.1
development/2.2
development/3.0

Please check the status of the associated issue ARTESCA-14731.

Goodbye ziyang-lin-404.

ziyang-lin-404 added 5 commits April 4, 2025 15:56

Add unit tests for CreateOrSelectNameField component

1cb4cb5

Enhance ISVConfiguration tests with additional scenarios and selector…

8ab113f

…s for improved readability. Update mocks and assertions for IAM user and account selection, ensuring proper validation and error handling for duplicate entries.

Implement additional test cases for ISVConfiguration, including skip …

bdf7ef7

…modal visibility, Continue button state validation, and navigation logic for multiple buckets. Remove deprecated test cases for improved clarity.

Add unit tests for CapacityFormSection and CapacityFormWithXcore comp…

fc98a9f

…onents

Update build-push-tests.yml

c30b03a

Refactor ISVConfiguration test to use 'await' for waitFor, ensuring p…

b0a349a

…roper asynchronous handling in the test case.

ziyang-lin-404 closed this Apr 16, 2025

ziyang-lin-404 reopened this Apr 16, 2025

ziyang-lin-404 added 2 commits April 16, 2025 15:20

Update security.yaml

070eb20

Update security.yaml

835c344

ziyang-lin-404 requested a review from JBWatenbergScality April 16, 2025 14:57

JBWatenbergScality approved these changes May 5, 2025

View reviewed changes

Refactor ISVConfiguration test to use fireEvent for input changes.

d3f1ba9

bert-e merged commit d23353f into development/3.1 Jun 30, 2025
9 checks passed

bert-e deleted the improvement/ARTESCA-14731-assistant-unit-tests branch June 30, 2025 15:30

Improve unit testing for ISV assistant component #842

Improve unit testing for ISV assistant component #842

Uh oh!

Conversation

ziyang-lin-404 commented Apr 16, 2025

Uh oh!

bert-e commented Apr 16, 2025

Hello ziyang-lin-404,

Uh oh!

bert-e commented Apr 16, 2025

Request integration branches

Uh oh!

JBWatenbergScality commented May 5, 2025

Uh oh!

bert-e commented May 5, 2025

Request integration branches

Uh oh!

JBWatenbergScality commented May 5, 2025

Uh oh!

bert-e commented May 5, 2025

Integration data created

Uh oh!

bert-e commented May 5, 2025

History mismatch

Uh oh!

JBWatenbergScality commented May 13, 2025

Uh oh!

bert-e commented May 13, 2025

Reset complete

Uh oh!

bert-e commented May 13, 2025

Integration data created

Uh oh!

bert-e commented May 13, 2025

Build failed

Uh oh!

ziyang-lin-404 commented Jun 30, 2025

Uh oh!

bert-e commented Jun 30, 2025

Status

Uh oh!

bert-e commented Jun 30, 2025

Integration data created

Uh oh!

bert-e commented Jun 30, 2025

Build failed

Uh oh!

bert-e commented Jun 30, 2025

Build failed

Uh oh!

bert-e commented Jun 30, 2025

Build failed

Uh oh!

ziyang-lin-404 commented Jun 30, 2025

Uh oh!

bert-e commented Jun 30, 2025

Status

Uh oh!

bert-e commented Jun 30, 2025

Build failed

Uh oh!

ziyang-lin-404 commented Jun 30, 2025

Uh oh!

bert-e commented Jun 30, 2025

Status

Uh oh!

bert-e commented Jun 30, 2025

In the queue

Uh oh!

bert-e commented Jun 30, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants