Skip to content

Conversation

Hyperkid123
Copy link
Member

Changes

Set the loading flag og the remote hook on the hook executor render.

Prior to this change, your hook result could be undefined while the loading was set to false. This has occured for one render cycle. Though the hook result would always show up, this issue could cause bugs and unexpected runtime errors.

@Hyperkid123 Hyperkid123 requested a review from a team as a code owner October 13, 2025 08:43
Copy link

nx-cloud bot commented Oct 13, 2025

View your CI Pipeline Execution ↗ for commit fe768bf

Command Status Duration Result
nx run test-app:serve ✅ Succeeded 1m 18s View ↗
nx affected -t component-test --configuration=ci ✅ Succeeded 29s View ↗
nx affected -t build ✅ Succeeded 26s View ↗
nx affected -t test --configuration=ci ✅ Succeeded 9s View ↗
nx affected -t lint ✅ Succeeded 2s View ↗

☁️ Nx Cloud last updated this comment at 2025-10-13 08:48:48 UTC

@Hyperkid123 Hyperkid123 merged commit eca3de6 into main Oct 13, 2025
8 checks passed
@Hyperkid123 Hyperkid123 deleted the remove-hook-result-undefined branch October 13, 2025 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant