Skip to content

fix(react-core): set loading flag on remote hook render #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 13, 2025
Merged

fix(react-core): set loading flag on remote hook render #160

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/react-core/src/remote-hook-provider.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,8 @@ function HookExecutor({

// Update state with the result
useEffect(() => {
updateState(id, { hookResult });
// always set loading to false when we have a result
updateState(id, { loading: false, hookResult });
}, [hookResult, id, updateState]);

return null;
Expand Down
1 change: 0 additions & 1 deletion packages/react-core/src/use-remote-hook.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ export const useRemoteHook = <T>({

// Only update if component is still mounted
if (isMounted) {
updateState(id, { loading: false, error: null });
updateArgs(id, args); // Set args before registering hook
registerHook(id, hookFunction);
}
Expand Down