feature: FillFormat.transparency#140
feature: FillFormat.transparency#140jonastr wants to merge 1 commit intoscanny:masterfrom jonastr:shape_alpha
Conversation
|
Thanks @jonastr, I believe this property should actually be on the fill property and we'll want to call it But no need to change the code if it's working for you. If you want to pursue a commit you'll need to provide a feature analysis (proposal) page, an acceptance test, unit tests, and a series of commits consistent with the conventions of the project. Let me know if you're interested in that and I can give you more details. Otherwise we'll keep this on file and use it to inform the implementation when we get to it, before long I'm sure :) |
|
@scanny Mhhh... I guess the 'correct' place depends on how you're looking at it. 😄 I put it in Other than that... I was expecting some more constraints before this feature can be merged. :) Unfortunately, I can't invest more time to make the code/commit compliant to your requirements. Therefore, I'll stick with my implementation for now. Of course, please feel free to improve as needed and copy to the official solution whatever you think makes sense. |
|
Of course, as you say, there will always be a certain amount of arbitrariness in the design decisions. And I'm not entirely sure we won't end up attaching it to color after all, depending on the analysis of what the behavior is of PowerPoint itself when you set the Grateful for the pull request, these come in handy when implementing the general case :) |
|
Produced my own fix before coming across these pull requests. I would be interested to put together feature analysis, look at the 2 contributions, compare them to my own implementation and see if we can formalize this feature. Would be good to get some more details on what are the requirements for the contribution to be accepted. |
|
Hey @scanny , is there any plan to include this PR to add support for FillFormat.transparency 🙏 |
example usage: