Feature: Convenience method to get a shape by its name#798
Open
lthamm wants to merge 1 commit intoscanny:developfrom
Open
Feature: Convenience method to get a shape by its name#798lthamm wants to merge 1 commit intoscanny:developfrom
lthamm wants to merge 1 commit intoscanny:developfrom
Conversation
|
Closes #309. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I find it very unpleasant in complex, living documents to work with the idx of a shape, because it always requires a map of idx to the shape.
The signature of the proposed _BaseShape.get_by_name is equal to the one of the method for layouts.