Prefer system-provided library for Catch2 #268
Merged
Conversation
Use the system-provided Catch2 library when available before falling back to fetching the library from upstream if the library is not found on the system. Signed-off-by: Christopher Obbard <obbardc@debian.org>
The postprocessing test includes catch2/catch_approx.cpp which is an internal source file and not shipped in the Catch2 v3 development package. Switch to including the public catch2/catch_approx.hpp header instead. Signed-off-by: Christopher Obbard <obbardc@debian.org>
Collaborator
|
LGTM. While we're at it, we might as well change the FetchContent to a newer Catch2 version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For distro packages it is prefereable to use system-provided packages. Use the system-provided library if available.