Prefer fetching Catch2 from source when on MacOS doing a universal build#270
Merged
Prefer fetching Catch2 from source when on MacOS doing a universal build#270
Conversation
…has Catch2 via homebrew. New behavior: * Single-arch build (including native arm64 on your Mac): defaults ON → finds Homebrew Catch2 as before. * -DCMAKE_OSX_ARCHITECTURES="arm64;x86_64": defaults OFF → falls through to FetchContent, which builds Catch2 for both archs. * Either default can be overridden explicitly with -DLSL_TESTS_PREFER_SYSTEM_CATCH2=ON/OFF.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recent change to find Catch2 breaks MacOS universal builds when user has Catch2 via homebrew. New behavior: