Lambda initializers #69
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lizers (already supported in manylinux1's GCC 4.7)
Collaborator
Author
|
Note: the CI for my repository also runs dockerized manylinux1 and manylinux2010 builds and both are succeeding. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our oldest compiler (RHEL 5, GCC 4.7 for manylinux1) only has full support for C++11, but partial support for lambda initializers (e.g.
[shared_this = shared_from_this()]() { shared_this->do_cancel(); }) so we should use it. Also avoid implicitthisin closures when we have ashared_ptrpointing to the object.