fix(ios): wire model-viewer + multi-model deep-link routes (closes #1015)#1020
Merged
Conversation
) The `DemoDeepLinkRegistry.allowedIds` whitelist had `model-viewer` and `multi-model` listed but the `destination(for:)` switch had no cases for either — they fell to the default branch which routes to the "Coming soon" placeholder. Result: any user scanning a QR code from sceneview.github.io that points at `sceneview://demo/model-viewer` (the helmet hero — also the App Store listing screenshot) dead-ended on a sablier icon instead of seeing real 3D content. Surfaced by Agent 3 of the v4.1.0 5-agent post-ship audit. iOS doesn't have 1:1 ports of Android's `ModelViewerDemo` (single hero model, orbit camera) or `MultiModelDemo` (tabletop). The Sketchfab Explore tab IS the canonical iOS model-viewer experience, but it's a Tab in the main TabView — not a standalone View we can present modally from a deep-link sheet. So route both ids to `SceneGalleryDemo` (the composed multi-shape scene): user lands on real 3D content instead of the placeholder. A doc-comment in the switch explains the iOS↔Android mapping rationale so the next contributor doesn't undo it. Closes #1015. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1015 (Agent 3 finding of the v4.1.0 audit).
DemoDeepLinkRegistry.allowedIdshadmodel-viewer+multi-modellisted butdestination(for:)had no cases — they fell to the default branch = "Coming soon" placeholder. Any QR scan ofsceneview://demo/model-viewer(the helmet hero on the App Store listing) dead-ended.iOS doesn't have 1:1 ports of those Android demos. The Sketchfab Explore tab IS the canonical iOS model-viewer experience but it's a Tab inside TabView (not modally presentable). Route both ids to
SceneGalleryDemoso user lands on real 3D content (composed multi-shape scene) instead of the placeholder. Mapping rationale documented inline.Build green on iOS simulator.