Enumerate devices on linux #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kisielk
reviewed
Feb 23, 2017
kisielk
left a comment
kisielk
left a comment
There was a problem hiding this comment.
API looks good to me. A few comments about memory leakage.
midi_linux.go
Outdated
| if rc := C.snd_ctl_open(&ctl, name, 0); rc != 0 { | ||
| return nil, alsaMidiError(rc) | ||
| } | ||
| C.free(unsafe.Pointer(name)) |
There was a problem hiding this comment.
This will leak memory if rc != 0. Should probably use defer after the C.Cstring allocation.
|
|
||
| func getDeviceDevices(ctl *C.snd_ctl_t, card C.int, device C.uint) ([]*Device, error) { | ||
| var info *C.snd_rawmidi_info_t | ||
| C.snd_rawmidi_info_malloc(&info) |
There was a problem hiding this comment.
This probably needs to be freed somewhere?
midi_linux.go
Outdated
| return errors.Errorf("error opening device %d", result.error) | ||
| } | ||
| d.conn = result.midi | ||
| C.free(unsafe.Pointer(id)) |
There was a problem hiding this comment.
This will leak id if result.error is != 0. You should probably just use defer C.free right after the call to C.CString
Contributor
Author
|
@kisielk thanks for the review. I'll take a look at implementing the same API on mac |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed API for #1