Skip to content

scx_bpfland: Simplify idle_smt conditional in kick_idle_cpu #2007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 28, 2025
Merged

scx_bpfland: Simplify idle_smt conditional in kick_idle_cpu #2007

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions scheds/rust/scx_bpfland/src/bpf/main.bpf.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ const volatile bool no_wake_sync;
*/
const volatile bool local_kthreads;

/*
/*
* Prioritize per-CPU tasks (tasks that can only run on a single CPU).
*
* This allows to prioritize per-CPU tasks that usually tend to be
Expand Down Expand Up @@ -432,7 +432,7 @@ static void task_update_domain(struct task_struct *p, struct task_ctx *tctx,

/*
* Refresh task's recently used CPU every time the task's domain
* is updated..
* is updated.
*/
tctx->recent_used_cpu = cpu;

Expand Down Expand Up @@ -854,7 +854,7 @@ static bool kick_idle_cpu(const struct task_struct *p, const struct task_ctx *tc
/*
* Try to reuse the same CPU if idle.
*/
if (!idle_smt || (idle_smt && is_fully_idle(prev_cpu))) {
if (!idle_smt || is_fully_idle(prev_cpu)) {
if (scx_bpf_test_and_clear_cpu_idle(prev_cpu)) {
scx_bpf_kick_cpu(prev_cpu, SCX_KICK_IDLE);
return true;
Expand Down