scx_p2dq: Refactor arena initialization #2009
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hodgesds
force-pushed
the
p2dq-lib-refactor
branch
from
2eca442 to
107b100
Compare
hodgesds
changed the title
hodgesds
force-pushed
the
p2dq-lib-refactor
branch
from
107b100 to
60e345b
Compare
hodgesds
force-pushed
the
p2dq-lib-refactor
branch
from
5065383 to
7288e30
Compare
Refactor p2dq initialization to be simple and use a set of helper functions. The trait on generated code creates unnecessary complexity for packaging. Signed-off-by: Daniel Hodges <hodgesd@meta.com>
hodgesds
force-pushed
the
p2dq-lib-refactor
branch
from
7288e30 to
a771043
Compare
likewhatevs
approved these changes
May 28, 2025
Contributor
likewhatevs
left a comment
likewhatevs
left a comment
There was a problem hiding this comment.
signals green lets do it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor p2dq initialization to be simple and use a set of helper functions. The trait on generated code creates unnecessary complexity for packaging.