Skip to content

scx_p2dq: Fix stalls in affinitized tasks #2014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 28, 2025
Merged

scx_p2dq: Fix stalls in affinitized tasks #2014

merged 1 commit into from
May 28, 2025

Conversation

@hodgesds
Copy link
Contributor

@hodgesds hodgesds commented May 28, 2025 •
edited
Loading

When selecting an idle CPU mask for affinitized tasks reset the temporary CPU mask used for finding an idle CPU. This fixes stalls in affinitized task handling under heavy load.

Tested with:

$ stress-ng --affinity-rand  --affinity 170 -t 35 -c 100 --affinity-delay 10 --affinity-sleep 10
stress-ng: info:  [334880] setting to a 35 secs run per stressor
stress-ng: info:  [334880] dispatching hogs: 170 affinity, 100 cpu
stress-ng: info:  [334880] skipped: 0
stress-ng: info:  [334880] passed: 270: affinity (170) cpu (100)
stress-ng: info:  [334880] failed: 0
stress-ng: info:  [334880] metrics untrustworthy: 0
stress-ng: info:  [334880] successful run completed in 35.08 secs

@hodgesds hodgesds added this pull request to the merge queue May 28, 2025
@hodgesds hodgesds removed this pull request from the merge queue due to a manual request May 28, 2025
@hodgesds
scx_p2dq: Fix stalls in affinitized tasks
91f49a1 
When selecting an idle CPU mask for affinitized tasks reset the
temporary CPU mask used for finding an idle CPU. This fixes stalls in
affinitized task handling under heavy load.

Signed-off-by: Daniel Hodges <hodgesd@meta.com>
@hodgesds hodgesds force-pushed the p2dq-affinitized-stalls branch from b51ab7c to 91f49a1 Compare May 28, 2025 15:03
@hodgesds hodgesds enabled auto-merge May 28, 2025 15:03
@hodgesds hodgesds added this pull request to the merge queue May 28, 2025
Merged via the queue into sched-ext:main with commit 034ba75 May 28, 2025
16 checks passed
@hodgesds hodgesds deleted the p2dq-affinitized-stalls branch May 28, 2025 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JakeHillion JakeHillion JakeHillion approved these changes

@etsal etsal etsal approved these changes

@likewhatevs likewhatevs likewhatevs approved these changes

@arighi arighi Awaiting requested review from arighi

@htejun htejun Awaiting requested review from htejun

@multics69 multics69 Awaiting requested review from multics69

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hodgesds @JakeHillion @etsal @likewhatevs