lib, scx_p2dq: factor out arena interface programs #2015
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I wonder if it's easier/more maintainable to have a separate compilation unit for the arena setup. I don't have a good idea of which way is better though. |
Contributor
Author
I assume ym having a separate Rust file that interfaces with the arena API? We can try that, I think it should be possible with subskeletons in such a way that it is usable by all schedulers without scheduler-specific code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the BPF arena API into a separate file, where it can be reused by multiple schedulers. Add argument passing to the functions to parameterize the initialization process.