Merged
Conversation
- Bump version in package.json and package-lock.json to 6.0.0-beta.0 - Update test script to run without watch - Upgrade tslib to ^2.8.1 - Upgrade @angular-eslint packages to ^21.3.0 - Update eslint to ^9.0.0 and angular-eslint to ^21.3.0 - Add typescript-eslint to dependencies
…o pythons/angular-21-upgrade
…int upgrade Co-authored-by: so-kaushal <28099586+so-kaushal@users.noreply.github.com>
…ublish command to include beta tag
docs: add 6.0.0-beta.0 changelog entry for Angular 21 / Node 24 / ESLint v9 upgrade
…kage.json and package-lock.json
…o pythons/angular-21-upgrade
sampada-ojha
approved these changes
Mar 26, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Upgrades the @oncehub/knowledgeowl-angular library to Angular 21, modernizes linting to ESLint v9 flat config with angular-eslint, and updates CI/publishing to match the new toolchain expectations.
Changes:
- Bumped Angular-related dependencies to v21.1.x, TypeScript to 5.9.x, and aligned tooling (ESLint v9 + flat config).
- Updated CI and publish workflows to use Node 24.14.0 and newer GitHub Actions.
- Released as a breaking change with version bump to 6.0.0 and added a changelog entry.
Reviewed changes
Copilot reviewed 8 out of 12 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| tsconfig.json | Removes explicit lib entries, relying on TS defaults for the configured target. |
| test/karma.conf.js | Whitespace-only cleanup. |
| src/tsconfig.lib.json | Simplifies compiler options by removing redundant lib config. |
| src/package.json | Bumps the package version used for the built/published artifact. |
| src/package-lock.json | Updates locked package version metadata. |
| package.json | Bumps version to 6.0.0 and updates scripts/deps for Angular 21 + ESLint 9 setup. |
| eslint.config.js | Introduces ESLint v9 flat config using typescript-eslint + angular-eslint. |
| CHANGELOG.md | Adds 6.0.0-beta.0 entry documenting breaking changes. |
| .github/workflows/npm-publish.yml | Updates checkout/setup-node actions and pins Node 24.14.0 for publishing. |
| .github/workflows/ci.yml | Updates checkout/setup-node actions and pins Node 24.14.0 for CI. |
| .eslintrc.json | Removes legacy ESLint config in favor of flat config. |
Files not reviewed (1)
- src/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
@so-kaushal I've opened a new pull request, #279, to work on those changes. Once the pull request is ready, I'll request review from you. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…knowledgeowl-angular into pythons/angular-21-upgrade
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ONCEHUB-112987
Upgrade knowledgeowl-angular library from Angular 20 to Angular 21
This pull request introduces a major upgrade to the project, primarily updating the Angular framework to version 21, raising the minimum required Node.js version to 24, and modernizing the ESLint configuration to use the new flat config format compatible with ESLint v9 and
angular-eslintv21. Several dependencies have been updated or replaced, and the CI/CD workflows have been modified to use the latest GitHub Actions. These changes are breaking and require consumers to update their environments accordingly.Framework and Dependency Upgrades:
ng-packagr,typescript, andtslib(BREAKING CHANGE).actions/checkoutandactions/setup-node. [1] [2] [3]6.0.0to reflect breaking changes. [1] [2] [3]Linting and Tooling Modernization:
.eslintrc.jsonconfiguration to the new flat config format ineslint.config.js, compatible with ESLint v9 andangular-eslintv21.3.0. This includes removing.eslintrc.jsonand consolidating linting plugins into the unifiedangular-eslintpackage. [1] [2] [3]@angular-eslint/*,@typescript-eslint/*,eslint-plugin-import,eslint-plugin-jsdoc,eslint-plugin-prefer-arrow) in favor of the unifiedangular-eslintpackage.Changelog and Publishing:
CHANGELOG.mddocumenting all breaking changes and major updates for version6.0.0-beta.0.betatag for pre-release publishing.Other Minor Changes:
tsconfig.lib.jsonby removing unnecessarylibentries.These changes are significant and require consumers to update their environments and configurations to match the new requirements.