commented lines: work with them, and leave comments intact#1
Open
ec1oud wants to merge 1 commit into
Open
Conversation
slic3r (on my Zeus) can generate gcode with comments adjacent to numbers, e.g. G0 X0 Y8 F4500; Go to pre-heat location so we have to split off the comments before assuming that every "word" after the initial letter is part of a number. Also, preserve unmodified any lines which are fully commented or which do not contain movements on the axis of interest. And use tabs for indentation (personal preference, especially for Python, such that 1 tab = one indent-level, and visual indentation in your editor is then just a matter of settings).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
slic3r (on my Zeus) can generate gcode with comments adjacent to
numbers, e.g.
G0 X0 Y8 F4500; Go to pre-heat location
so we have to split off the comments before assuming that every
"word" after the initial letter is part of a number.
Also, preserve unmodified any lines which are fully commented
or which do not contain movements on the axis of interest.
And use tabs for indentation (personal preference, especially for
Python, such that 1 tab = one indent-level, and visual indentation
in your editor is then just a matter of settings).