Add AspectRatio component with preset ratios and radius variants#38
Merged
Add AspectRatio component with preset ratios and radius variants#38
Conversation
…d width-to-height ratio. Fills a gap in the library: there was no primitive for keeping images, videos, and iframes at a consistent shape across viewport sizes. Implementation uses the modern CSS aspect-ratio property (no padding-bottom hack, no new Radix dependency required) and applies sensible defaults so direct <img>, <video>, and <iframe> children fill the container automatically (h-full w-full + object-cover for img/video; border-0 for iframe). Two ways to set the ratio: a numeric `ratio` prop (e.g. 16 / 9) for arbitrary values, or a named `preset` for common ratios (square 1:1, video 16:9, photo 4:3, wide 3:2, ultrawide 21:9, cinema ~2.35:1, portrait 3:4, classic-portrait 2:3, story 9:16). cva-driven `radius` variant (none, sm, md, lg, xl, 2xl, full) and `bordered` variant (uses border-border from @schemavaults/theme so it inherits brightness/contrast theming). asChild via Radix Slot so the aspect ratio can be applied directly to a child element (e.g. an <img> styled as a circular thumbnail). data-slot=aspect-ratio and data-preset attributes set on the root for downstream styling. Storybook story covers Default, Square, Ultrawide, VerticalStory, CustomRatio, Placeholder (icon + label inside a bordered box), IframeEmbed, VideoThumbnail (with hover-scale play icon overlay), AsChild, MediaCard (composing inside a card surface), and AllPresets / AllRadii grid views for at-a-glance comparison.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Introduces a new
AspectRatiocomponent that constrains content to fixed width-to-height ratios. This component is useful for images, videos, iframes, and embedded media that need to maintain consistent proportions across different viewport sizes.Key Changes
New AspectRatio component (
src/components/ui/aspect-ratio/aspect-ratio.tsx)ratioprop (e.g.,16 / 9) and namedpresetidentifierssquare,video,photo,wide,ultrawide,cinema,portrait,classic-portrait,storyaspect-ratioproperty with automatic fill behavior for<img>,<video>, and<iframe>childrenradiusvariant (none,sm,md,lg,xl,2xl,full)borderedvariant for visual containmentasChildprop via Radix Slot for applying aspect ratio directly to child elementsComprehensive Storybook stories (
src/components/ui/aspect-ratio/AspectRatio.stories.tsx)Module exports (
src/components/ui/aspect-ratio/index.ts)Updated main UI exports (
src/components/ui/index.ts)Version bump (
package.json)Implementation Details
ratioprop takes precedence overpresetwhen both are providedvideo(16:9) preset if neither ratio nor preset is specifiedimg,video,iframe) automatically fill container withobject-covercn()utilityhttps://claude.ai/code/session_016mDrJ8fdfxHjs7jyZzHd3A