Replace Suspense hydration pattern with useEffect in ThemeSelector#57
Merged
Conversation
…ct-driven mounted flag so the component no longer leaves an unresolved Suspense boundary in the SSR/static-prerender output (which was breaking Next.js 16 `next build` for consumers that put ThemeSelector on a statically prerendered route).
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactored the
ThemeSelectorcomponent to use auseEffect-based hydration pattern instead of React Suspense. This eliminates the need for Suspense boundaries and their fallback components while maintaining the same server/client hydration safety.Key Changes
useHasMounted()hook: Created a new custom hook that usesuseStateanduseEffectto track client-side mounting, replacing the previous promise-basedgetHydrationPromise()approachSegmentedThemeSelectorFallbackandCompactThemeSelectorFallbackas their logic is now integrated directly into the main componentsSegmentedThemeSelectorandCompactThemeSelectornow conditionally render disabled/inert controls during the initial render (beforeuseEffectruns), then swap to the real theme-aware UI after mountSuspensewrapper and consolidated the "Content" and "Fallback" component pairs into single unified componentsImplementation Details
The new
useHasMounted()hook returnsfalseon the server and during initial client hydration, thentrueafter the firstuseEffectruns. This ensures:Version bumped to 0.54.2.
https://claude.ai/code/session_01NUbaejFGHF9S2bcVKAZYj8