Skip to content

Conversation

@olekenneth
Copy link
Contributor

@olekenneth olekenneth commented Feb 10, 2023

Drop the .jojo-file from main screen. This will read the Jojo-file and take you to the editor.
You can then read the transcript and choose the audio file to play back segments from the file.
Changes will be stored in the current state of the page, to save, download the file.

Save/export

image

Mobile

image

Desktop

image
image

@olekenneth olekenneth changed the title Subtitle editor Offline editor of .jojo-files with audio playback Feb 12, 2023
@olekenneth olekenneth marked this pull request as ready for review February 12, 2023 21:31
@3ddyBoi 3ddyBoi added the type/feature Issue or PR related to a new feature label Feb 12, 2023
@3ddyBoi
Copy link
Member

3ddyBoi commented Feb 14, 2023

Drag and drop is broken for audio files, you do not get the settings modal.

@3ddyBoi
Copy link
Member

3ddyBoi commented Feb 14, 2023

You cant choose a jojo file when you click the choose file input button. Is this something that should be possible maybe?

@3ddyBoi
Copy link
Member

3ddyBoi commented Feb 14, 2023

The save button pushes the transcription box downwards.
We should use click instead of hover or perhaps the box could lie above the transcription field when you hover it?

@3ddyBoi
Copy link
Member

3ddyBoi commented Feb 14, 2023

Should the sound stop automatically when you have played the section of sound?

@olekenneth
Copy link
Contributor Author

Should the sound stop automatically when you have played the section of sound?

It could. But atm it will not.

The save button pushes the transcription box downwards.

We should use click instead of hover or perhaps the box could lie above the transcription field when you hover it?

This it's like this on mobile. Sort of intended. On desktop it's not an issue.

You cant choose a jojo file when you click the choose file input button. Is this something that should be possible maybe?

Fixed

Drag and drop is broken for audio files, you do not get the settings modal.

Fixed

@olekenneth olekenneth enabled auto-merge (squash) February 14, 2023 18:23
3ddyBoi
3ddyBoi previously approved these changes Feb 15, 2023
Copy link
Member

@3ddyBoi 3ddyBoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 💯

@olekenneth olekenneth disabled auto-merge February 16, 2023 05:23
@olekenneth olekenneth enabled auto-merge (squash) February 16, 2023 05:23
@olekenneth olekenneth merged commit 53b56eb into main Feb 16, 2023
@olekenneth olekenneth deleted the feat/editor branch February 16, 2023 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type/feature Issue or PR related to a new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants