Fix veg_lai and veg_cw type declaration: integer -> real#205
Merged
Conversation
These variables are incorrectly declared as integers but are used as real values (e.g., veg_cw=1.5). When users specify float values in param.nml, Fortran fails to parse the namelist: Error termination. Backtrace: At line 537 of file .../src/Hydro/schism_init.F90 (unit = 15, file = './/param.nml') Fortran runtime error: Cannot match namelist object name Move veg_lai and veg_cw from integer to real(rkind) declaration block.
tomsail
pushed a commit
to tomsail/schism
that referenced
this pull request
May 22, 2026
) These variables are incorrectly declared as integers but are used as real values (e.g., veg_cw=1.5). When users specify float values in param.nml, Fortran fails to parse the namelist: Error termination. Backtrace: At line 537 of file .../src/Hydro/schism_init.F90 (unit = 15, file = './/param.nml') Fortran runtime error: Cannot match namelist object name Move veg_lai and veg_cw from integer to real(rkind) declaration block.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These variables are incorrectly declared as integers but are used as real values (e.g., veg_cw=1.5). When users specify float values in param.nml (such those in the example_inputs/param.nml), Fortran fails to parse the namelist:
Moving veg_lai and veg_cw from integer to real(rkind) declaration block fixes the issue by making the declarations consistent.