Merge pull request #1069 from schmittjoh/groups-for-public

Expose and test GroupsExclusionStrategy::getGroupsFor()

Author: goetas

src/JMS/Serializer/Context.php

@@ -47,6 +47,7 @@ abstract class Context
     public function __construct()
     {
         $this->attributes = new Map();
+        $this->metadataStack = new \SplStack();
     }
 
     /**

src/JMS/Serializer/Exclusion/GroupsExclusionStrategy.php

@@ -82,8 +82,16 @@ private function shouldSkipUsingGroups(PropertyMetadata $property, $groups)
         return true;
     }
 
-    private function getGroupsFor(Context $navigatorContext)
+    /**
+     * @param Context $navigatorContext
+     * @return array
+     */
+    public function getGroupsFor(Context $navigatorContext)
     {
+        if (!$this->nestedGroups) {
+            return array_keys($this->groups);
+        }
+
         $paths = $navigatorContext->getCurrentPath();
 
         $groups = $this->groups;

tests/Exclusion/GroupsExclusionStrategyTest.php

@@ -49,4 +49,40 @@ public function getExclusionRules()
             [['foo'], [GroupsExclusionStrategy::DEFAULT_GROUP, 'foo'], false],
         ];
     }
+
+    /**
+     * @dataProvider getGroupsFor
+     * @param $groups
+     * @param $propsVisited
+     * @param $resultingGroups
+     */
+    public function testGroupsFor($groups, $propsVisited, $resultingGroups)
+    {
+        $exclusion = new GroupsExclusionStrategy($groups);
+        $context = SerializationContext::create();
+
+        foreach ($propsVisited as $prop) {
+            $metadata = new StaticPropertyMetadata('stdClass', $prop, 'propVal');
+            $context->pushPropertyMetadata($metadata);
+        }
+
+        $groupsFor = $exclusion->getGroupsFor($context);
+        $this->assertEquals($groupsFor, $resultingGroups);
+    }
+
+    public function getGroupsFor()
+    {
+        return [
+            [['foo'], ['prop'], ['foo']],
+            [[], ['prop'], ['Default']],
+
+            [['foo', 'prop' => ['bar']], ['prop'], ['bar']],
+            [['foo', 'prop' => ['bar']], ['prop2'], ['foo', 'prop' => ['bar']]],
+
+            [['foo', 'prop' => ['bar']], ['prop', 'prop2'], ['Default']],
+
+            [['foo', 'prop' => ['xx', 'prop2' => ['def'], 'prop3' => ['def']]], ['prop', 'prop2', 'propB'], ['Default']],
+            [['foo', 'prop' => ['xx', 'prop2' => ['def', 'prop3' => ['def']]]], ['prop', 'prop2'], ['def', 'prop3' => ['def']]],
+        ];
+    }
 }