Fix an Exception when an excluded property has no method accessors

Exception is thrown, if the class accessor is set to public_method, and there is an excluded property with no accessor

Author: 0mars

src/JMS/Serializer/Metadata/Driver/XmlDriver.php

@@ -160,6 +160,10 @@ protected function loadMetadataFromFile(\ReflectionClass $class, $path)
                         $isExclude = 'true' === strtolower($exclude);
                     }
 
+                    if ($isExclude) {
+                        continue;
+                    }
+
                     if (null !== $expose = $pElem->attributes()->expose) {
                         $isExpose = 'true' === strtolower($expose);
                     }

src/JMS/Serializer/Metadata/Driver/YamlDriver.php

@@ -91,6 +91,10 @@ protected function loadMetadataFromFile(\ReflectionClass $class, $file)
                         $isExclude = (Boolean)$pConfig['exclude'];
                     }
 
+                    if ($isExclude) {
+                        continue;
+                    }
+
                     if (isset($pConfig['expose'])) {
                         $isExpose = (Boolean)$pConfig['expose'];
                     }

tests/Fixtures/ExcludePublicAccessor.php

@@ -0,0 +1,50 @@
+<?php
+
+/*
+ * Copyright 2016 Johannes M. Schmitt <schmittjoh@gmail.com>
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+namespace JMS\Serializer\Tests\Fixtures;
+
+use JMS\Serializer\Annotation\AccessType;
+use JMS\Serializer\Annotation\Exclude;
+use JMS\Serializer\Annotation\ReadOnly;
+
+/**
+ */
+
+/**
+ * @AccessType("public_method")
+ * @ReadOnly
+ */
+class ExcludePublicAccessor
+{
+    /**
+     * @Exclude
+     *
+     * @var mixed
+     */
+    private $iShallNotBeAccessed;
+
+    /**
+     * @var int
+     */
+    private $id = 1;
+
+    public function getId()
+    {
+        return $this->id;
+    }
+}

tests/Metadata/Driver/BaseDriverTest.php

@@ -477,6 +477,17 @@ public function testExclusionIf()
         $this->assertEquals($p, $m->propertyMetadata['age']);
     }
 
+    public function testExcludePropertyNoPublicAccessorException()
+    {
+        $first = $this->getDriver()->loadMetadataForClass(new \ReflectionClass('JMS\Serializer\Tests\Fixtures\ExcludePublicAccessor'));
+
+        if ($this instanceof PhpDriverTest) {
+            return;
+        }
+        $this->assertArrayHasKey('id', $first->propertyMetadata);
+        $this->assertArrayNotHasKey('iShallNotBeAccessed', $first->propertyMetadata);
+    }
+
 
     /**
      * @return DriverInterface

tests/Metadata/Driver/DoctrineDriverTest.php

@@ -100,6 +100,15 @@ public function testNonDoctrineEntityClassIsNotModified()
         $this->assertEquals($plainMetadata, $doctrineMetadata);
     }
 
+    public function testExcludePropertyNoPublicAccessorException()
+    {
+        $first = $this->getAnnotationDriver()
+            ->loadMetadataForClass(new \ReflectionClass('JMS\Serializer\Tests\Fixtures\ExcludePublicAccessor'));
+
+        $this->assertArrayHasKey('id', $first->propertyMetadata);
+        $this->assertArrayNotHasKey('iShallNotBeAccessed', $first->propertyMetadata);
+    }
+
     public function testVirtualPropertiesAreNotModified()
     {
         $doctrineMetadata = $this->getMetadata();

tests/Metadata/Driver/xml/ExcludePublicAccessor.xml

@@ -0,0 +1,6 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<serializer>
+    <class name="JMS\Serializer\Tests\Fixtures\ExcludePublicAccessor" access-type="public_method" read-only="true">
+        <property name="iShallNotBeAccessed" exclude="true" />
+    </class>
+</serializer>

tests/Metadata/Driver/yml/ExcludePublicAccessor.yml

@@ -0,0 +1,6 @@
+JMS\Serializer\Tests\Fixtures\ExcludePublicAccessor:
+    access_type: public_method
+    read_only: false
+    properties:
+        iShallNotBeAccessed:
+          exclude: true