Handle unset and invalid values from editor config #47 #295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 9, 2024
Closed
Bartheleway
reviewed
Oct 10, 2024
Bartheleway
approved these changes
Oct 11, 2024
Contributor
Bartheleway
left a comment
Bartheleway
left a comment
There was a problem hiding this comment.
Looks all good for me. Up to you to add the change around the regexp or not 😉
schorfES
force-pushed
the
feat/editorconfig-unset-values
branch
2 times, most recently
from
e2ace5a to
17d3411
Compare
Co-authored-by: Barthélemy Laurans <bartheleway@gmail.com>
schorfES
force-pushed
the
feat/editorconfig-unset-values
branch
from
17d3411 to
cb1516f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #47 by implementing support for handling
'unset'or invalid values from EditorConfig. Specifically, it ensures that these values disable the corresponding settings, maintaining consistent behavior across configurations.