fix: reap child processes on session stop/kill#8
Merged
Conversation
captureOutput goroutine could exit via the done channel without calling cmd.Wait(), leaving terminated child processes as zombies in the process table. Moved cmd.Wait() and p.Close() into a defer so the child is always reaped regardless of exit path.
schovi
force-pushed
the
fix/zombie-process-reaping
branch
from
3290dbe to
f346e77
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
captureOutputgoroutine could exit via thedonechannel (closed byhandleStop/handleKill) without callingcmd.Wait(), leaving terminated child processes as zombies in the process tablecmd.Wait()andp.Close()into adeferso the child is always reaped regardless of exit path (done channel vs Read error)Test plan
make testpassesps aux | grep defunct)