Skip to content

fix: move build-setup.yml out of workflows dir#163

Merged
schpet merged 1 commit intoschpet:mainfrom
regaw-leinad:fix/move-build-setup-yml
Mar 5, 2026
Merged

fix: move build-setup.yml out of workflows dir#163
schpet merged 1 commit intoschpet:mainfrom
regaw-leinad:fix/move-build-setup-yml

Conversation

@regaw-leinad
Copy link
Contributor

noticed the build-setup.yml in .github/workflows/ causes a spurious failing action run on every push since github tries to parse it as a workflow.

moved it to .github/build-setup.yml and updated the cargo-dist path to "../build-setup.yml" (which is actually the example from their docs). tested on my fork and confirmed the failures stop and CI still passes.

btw really enjoying this cli, and thanks for the quick turnaround on the last pr!

@regaw-leinad
Copy link
Contributor Author

just found #125 which looks like the same fix, feel free to close if its something you already know won't work

@regaw-leinad
Copy link
Contributor Author

actually the diff in #125 had the path as .github/build-setup.yml (repo root) but cargo-dist resolves it relative to .github/workflows/, so it should be ../build-setup.yml which is what this pr does

@regaw-leinad regaw-leinad force-pushed the fix/move-build-setup-yml branch from 7a62dc4 to 9e70e53 Compare March 5, 2026 02:40
@schpet schpet merged commit 1f6b6ac into schpet:main Mar 5, 2026
7 checks passed
@schpet
Copy link
Owner

schpet commented Mar 5, 2026

very generous! been bugging me for a while but always low on my list, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants