Skip to content

fix: move date validation inside try-catch in project update #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
schpetbot merged 1 commit into from
Mar 5, 2026
Merged

fix: move date validation inside try-catch in project update #165

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 22 additions & 22 deletions src/commands/project/project-update.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,33 +83,33 @@ export const updateCommand = new Command()
},
projectId,
) => {
if (
!name && description == null && !status && !lead &&
!startDate && !targetDate && (!teams || teams.length === 0)
) {
throw new ValidationError(
"At least one update option must be provided",
{
suggestion:
"Use --name, --description, --status, --lead, --start-date, --target-date, or --team",
},
)
}

if (startDate && !/^\d{4}-\d{2}-\d{2}$/.test(startDate)) {
throw new ValidationError("Start date must be in YYYY-MM-DD format")
}

if (targetDate && !/^\d{4}-\d{2}-\d{2}$/.test(targetDate)) {
throw new ValidationError("Target date must be in YYYY-MM-DD format")
}

const { Spinner } = await import("@std/cli/unstable-spinner")
const showSpinner = shouldShowSpinner()
const spinner = showSpinner ? new Spinner() : null
spinner?.start()

try {
if (
!name && description == null && !status && !lead &&
!startDate && !targetDate && (!teams || teams.length === 0)
) {
throw new ValidationError(
"At least one update option must be provided",
{
suggestion:
"Use --name, --description, --status, --lead, --start-date, --target-date, or --team",
},
)
}

if (startDate && !/^\d{4}-\d{2}-\d{2}$/.test(startDate)) {
throw new ValidationError("Start date must be in YYYY-MM-DD format")
}

if (targetDate && !/^\d{4}-\d{2}-\d{2}$/.test(targetDate)) {
throw new ValidationError("Target date must be in YYYY-MM-DD format")
}

spinner?.start()
const client = getGraphQLClient()
const resolvedId = await resolveProjectId(projectId)

Expand Down