Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements an option to switch between building shared and static libraries. This is more or less the same I did in maeparser (schrodinger/maeparser#57). Please note that this PR depends on the one in maeparser, and should not be merged before that one.
Added the
COORDGEN_BUILD_SHARED_LIBSflag:ON== shared library,OFF== static. The required dependencies (boost, zlib), as well as the unit tests, will use the same linking type as specified by the flag. If maeparser needs to be built from source, it will also use the same linking type as indicated here.In the tests: removed the
BOOST_TEST_DYN_LINKmacro.Added some new Azure pipelines to build static libs. These have also been reformatted, looking like bigger changes that they actually are.
These changes have also been tested in my CI builds (https://dev.azure.com/ricrogz/mycoordgen/_build/results?buildId=391).
Please note that the Travis and appveyor builds do neither exercise the static builds.
As mentioned in the maeparser PR, I tested that, one these changes are live in maeparser and coordgen, RDKit and Openbabel won't break, and will still be able to build without any changes.