Don't copy vector when not needed.#48
Merged
d-b-w merged 1 commit intoschrodinger:masterfrom Feb 12, 2020
Merged
Conversation
The copy of the bonds vector was, seriously, 10% of total duration for some example molecules that I looked at. (because of copies that occured while checking whether some atom is terminal) Also fixes an extra copy for the ring vector, but that doesn't have an impact that I know of. It's just odd.
JarrettSJohnson
approved these changes
Feb 12, 2020
Member
JarrettSJohnson
left a comment
JarrettSJohnson
left a comment
There was a problem hiding this comment.
Sorry; I just now saw this review request. I experienced this too and suggested this change as well in the other review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The copy of the bonds vector was, seriously, 10% of total
duration for some example molecules that I looked at.
(because of copies that occured while checking whether
some atom is terminal)
Also fixes an extra copy for the ring vector, but that
doesn't have an impact that I know of. It's just odd.