Garante que seja apresentado o gráfico de Sushi somente para a coleção Brasil#160
Merged
gitnnolabs merged 3 commits intoscieloorg:masterfrom Mar 10, 2022
Merged
Conversation
Comment on lines
35
to
37
| <div class="col-md-6"> | ||
| <%include file="access_by_month_and_year.mako"/> | ||
| </div> |
Contributor
Author
There was a problem hiding this comment.
Ah! entendi para só apresenta o Sushi.
rafaelpezzuto
suggested changes
Mar 10, 2022
Contributor
rafaelpezzuto
left a comment
rafaelpezzuto
left a comment
There was a problem hiding this comment.
É preciso inserir esse mesmo if/else no template home_journal.mako:
Contributor
Author
|
Vou ajustar |
Comment on lines
+37
to
+39
| <div class="col-md-6"> | ||
| <%include file="publication_article_affiliations_map.mako"/> | ||
| </div> |
Member
There was a problem hiding this comment.
@gitnnolabs este gráfico fica fora do else porque é outra coisa (afiliações)
e trocar <div class="col-md-6"> por <div class="col-md-12">
Contributor
Author
|
@rafaelpezzuto e @robertatakenaka Ajustado! Agora vai Brasil!!! |
gitnnolabs
force-pushed
the
fix_sushi_grafic
branch
from
b29f2dc to
dcca097
Compare
gitnnolabs
changed the title
rafaelpezzuto
approved these changes
Mar 10, 2022
Contributor
rafaelpezzuto
left a comment
rafaelpezzuto
left a comment
There was a problem hiding this comment.
Chegou a ver se o gráfico de afiliações fica bonito estando muito grande (col-md-12)?
De qualquer forma, o PR atende ao que foi pedido.
robertatakenaka
approved these changes
Mar 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
O que esse PR faz?
Garanti que seja apresentado o gráfico de Sushi somente para a coleção Brasil
Onde a revisão poderia começar?
Por commit
Como este poderia ser testado manualmente?
Acessando uma instância local com o ajuste.
Algum cenário de contexto que queira dar?
Por hora não temos os dados do Sushi no nível da rede.
Screenshots
Sem Sushi
Coleção Brasil com Sushi
Quais são tickets relevantes?
N/A
Referências
N/A