Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion journalpage/templates/journalpage/about.html
Original file line number Diff line number Diff line change
Expand Up @@ -543,7 +543,7 @@ <h5 id="item-4-9">{% trans 'Informações adicionais' %}</h5>
<div class="row">
<div class="col">
<p class="page-updated-at">
<small>Atualizado: {{journal.updated}}</small>
<small>{% trans 'Atualizado' %}: {{journal.updated}}</small>
</p>
</div>
</div>
Expand Down
12 changes: 6 additions & 6 deletions journalpage/templates/journalpage/base.html
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,8 @@
<div class="modal-dialog modal-sm">
<div class="modal-content">
<div class="modal-header">
<button type="button" class="close" data-dismiss="modal"><span aria-hidden="true">×</span><span class="sr-only">Close</span></button>
<h4 class="modal-title">Mensagem</h4>
<button type="button" class="close" data-dismiss="modal"><span aria-hidden="true">×</span><span class="sr-only">{% trans 'Close' %}</span></button>
<h4 class="modal-title">{% trans 'Mensagem' %}</h4>
</div>
<div class="modal-body">
<div class="midGlyph">
Expand All @@ -65,8 +65,8 @@ <h4 class="modal-title">Mensagem</h4>
<div class="modal-dialog modal-sm">
<div class="modal-content">
<div class="modal-header">
<button type="button" class="close" data-dismiss="modal"><span aria-hidden="true">×</span><span class="sr-only">Close</span></button>
<h4 class="modal-title">Mensagem</h4>
<button type="button" class="close" data-dismiss="modal"><span aria-hidden="true">×</span><span class="sr-only">{% trans 'Close' %}</span></button>
<h4 class="modal-title">{% trans 'Mensagem' %}</h4>
</div>
<div class="modal-body">
<div class="midGlyph">
Expand All @@ -77,7 +77,7 @@ <h4 class="modal-title">Mensagem</h4>
</div>

<!-- Error modal -->
<a class="floatingBtnError btn btn-danger" href="#" id="#floatingBtnError">Reportar erro</a>
<a class="floatingBtnError btn btn-danger" href="#" id="#floatingBtnError">{% trans 'Reportar erro' %}</a>

<!-- Scielo Bundle min -->
<script src="{% static 'journal_about/js/scielo-bundle-min.js' %}"></script>
Expand Down Expand Up @@ -173,7 +173,7 @@ <h4 class="modal-title">Mensagem</h4>
<div class="bugherd" style="display:none;">
<div class="bugherd=container">
<div class="btn-group" role="group" aria-label="...">
<a href="//github.com/scieloorg/opac/issues/new" target="_blank" class="btn btn-danger">Reportar erro</a>
<a href="//github.com/scieloorg/opac/issues/new" target="_blank" class="btn btn-danger">{% trans 'Reportar erro' %}</a>
</div>
</div>
</div>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
{% load static compress %}
{% load i18n %}

<section class="journalContacts pt-4 pb-4">
<div class="container">
Expand All @@ -15,7 +16,7 @@
{% endif %}
{% if journal.journal_email.all %}
{% for email in journal.journal_email.all %}
<strong>E-mail:</strong> {{ email.email }}
<strong>{% trans 'E-mail' %}:</strong> {{ email.email }}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Não precisa de tag trans para E-mail

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@samuelveigarangel precisamos estar preparados para outros idiomas que não en, es, pt.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E-mail não é universal ?

{% endfor%}
{% endif %}
</div>
Expand All @@ -25,7 +26,7 @@
<div class="col-12 col-sm-4 text-center text-sm-start pt-4 pt-sm-0">
<a href="#" data-toggle="tooltip" title="RSS do número mais recente do periódico" target="_blank"><span class="material-icons-outlined">rss_feed</span></a>
Copy link

Copilot AI Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

O atributo title do tooltip contém texto visível ao usuário não marcado para tradução ("RSS do número mais recente do periódico"). Envolva o valor do title com {% trans %} (ou use {% blocktrans %} se precisar interpolar variáveis) para garantir que seja extraído pelo makemessages.

Copilot uses AI. Check for mistakes.
<span>
Acompanhe os números deste periódico no seu leitor de RSS
{% trans 'Acompanhe os números deste periódico no seu leitor de RSS' %}
</span>
{% for sn in journal.social_networks %}
<a href="{{sn.account}}" data-toggle="tooltip" title="{{sn.network|title}}">
Expand All @@ -42,7 +43,7 @@
>
</span>
{% if loop.last %}
Copy link

Copilot AI Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Em templates Django, a flag de último item do loop é forloop.last, não loop.last. Do jeito atual a condição nunca é verdadeira e o texto final não é renderizado. Substitua por forloop.last.

Suggested change
{% if loop.last %}
{% if forloop.last %}

Copilot uses AI. Check for mistakes.
<span class="text">Siga este periódico nas redes sociais</span>
<span class="text">{% trans 'Siga este periódico nas redes sociais' %}</span>
{% endif %}
{% endfor %}
</div>
Expand Down
3 changes: 2 additions & 1 deletion journalpage/templates/journalpage/includes/footer.html
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
{% load static compress %}
{% load i18n %}

<footer>
<section class="address-scielo pt-4 pb-4 mt-5">
Expand Down Expand Up @@ -54,7 +55,7 @@
<a href="#">
<img src="{% static 'journal_about/img/logo-open-access.svg' %}" alt="Open Access" class="logo-open-access">
</a>
<a href="#">Leia</a> a Declaração de Acesso Aberto
{% blocktrans %}<a href="#">Leia</a> a Declaração de Acesso Aberto{% endblocktrans %}
</p>
Comment on lines +58 to 59
Copy link

Copilot AI Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usar <a ...> diretamente dentro de {% blocktrans %} faz o msgid conter HTML, o que é mais difícil/arriscado para tradutores e dificulta reordenação do texto em outros idiomas. Prefira blocktrans com placeholders (ex.: passando o link como variável ou usando marcadores para início/fim do link) para manter o HTML fora da string traduzível.

Copilot uses AI. Check for mistakes.
</div>
</div>
Expand Down
14 changes: 7 additions & 7 deletions journalpage/templates/journalpage/includes/header.html
Original file line number Diff line number Diff line change
Expand Up @@ -92,23 +92,23 @@
</li>
{% if journal.online_submission_url and journal.current_status == 'current' %}
<li>
<a href="#" class="dropdown-item" target="_blank"><span class="material-icons-outlined">launch</span> Submissão de manuscritos</a>
<a href="#" class="dropdown-item" target="_blank"><span class="material-icons-outlined">launch</span> {% trans 'Submissão de manuscritos' %}</a>
</li>
{% endif %}
<li>
<a href="#about" class="dropdown-item"><span class="material-icons-outlined">info</span> Sobre o periódico</a>
<a href="#about" class="dropdown-item"><span class="material-icons-outlined">info</span> {% trans 'Sobre o periódico' %}</a>
</li>
<li>
<a href="#editors" class="dropdown-item"><span class="material-icons-outlined">people</span> Corpo Editorial</a>
<a href="#editors" class="dropdown-item"><span class="material-icons-outlined">people</span> {% trans 'Corpo Editorial' %}</a>
</li>
<li>
<a href="#instructions" class="dropdown-item"><span class="material-icons-outlined">help_outline</span> Instruções aos autores</a>
<a href="#instructions" class="dropdown-item"><span class="material-icons-outlined">help_outline</span> {% trans 'Instruções aos autores' %}</a>
</li>
<li>
<a href="#item2" class="dropdown-item"><span class="material-icons-outlined">help_outline</span> Política editorial</a>
<a href="#item2" class="dropdown-item"><span class="material-icons-outlined">help_outline</span> {% trans 'Política editorial' %}</a>
</li>
<li>
<a href="#contact" class="dropdown-item"><span class="material-icons-outlined">email</span> Contato</a>
<a href="#contact" class="dropdown-item"><span class="material-icons-outlined">email</span> {% trans 'Contato' %}</a>
</li>
</ul>
</div>
Expand All @@ -135,7 +135,7 @@
</li>
{% if journal.online_submission_url and journal.current_status == 'current' %}
<li>
<a href="#" class="dropdown-item" target="_blank"><span class="material-icons-outlined">launch</span> Submissão de manuscritos</a>
<a href="#" class="dropdown-item" target="_blank"><span class="material-icons-outlined">launch</span> {% trans 'Submissão de manuscritos' %}</a>
</li>
{% endif %}
<li>
Expand Down
10 changes: 5 additions & 5 deletions journalpage/templates/journalpage/includes/journal_info.html
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ <h1 class="h4" style="margin: 1rem auto">
<!-- Ini - Se houver um outro título-->
{% if journal.next_title %}
<span class="otherTitle">
<span>Novo título:</span>
<span>{% trans 'Novo título' %}:</span>
{% if journal.url_next_journal %}
<a href="#" class="NewCollectionLink">
{{ journal.next_title }}
Expand All @@ -67,7 +67,7 @@ <h1 class="h4" style="margin: 1rem auto">
<!-- Ini - Se houver um outro título antigo -->
{% if journal.previous_journal_ref %}
<span class="otherTitle">
<span>Título anterior:</span>
<span>{% trans 'Título anterior' %}:</span>
{% if journal.url_previous_journal %}
<a href="#" class="NewCollectionLink">
{{ journal.previous_journal_ref }}
Expand All @@ -84,21 +84,21 @@ <h1 class="h4" style="margin: 1rem auto">
<div class="col-3 pt-5">
<div class="list-group">
{% if journal.online_submission_url and journal.current_status == 'current' %}
<a class="list-group-item" href="{{ journal.online_submission_url }}" target="_blank"><span class="material-icons-outlined">launch</span> Submissão de manuscritos</a>
<a class="list-group-item" href="{{ journal.online_submission_url }}" target="_blank"><span class="material-icons-outlined">launch</span> {% trans 'Submissão de manuscritos' %}</a>
{% endif %}
<a class="list-group-item" href="{% routablepageurl page 'bibliographic' acron_collection acron_journal %}#item-1"><span class="material-icons-outlined">info</span> {% trans 'Sobre o periódico' %}</a>
<a class="list-group-item" href="{% routablepageurl page 'bibliographic' acron_collection acron_journal %}#item-3"><span class="material-icons-outlined">people</span> {% trans 'Corpo Editorial' %}</a>
<a class="list-group-item" href="{% routablepageurl page 'bibliographic' acron_collection acron_journal %}#item-4"><span class="material-icons-outlined">help_outline</span> {% trans 'Instruções aos autores' %}</a>
<a class="list-group-item" href="{% routablepageurl page 'bibliographic' acron_collection acron_journal %}#item-2"><span class="material-icons-outlined">article</span> {% trans 'Política editorial' %}</a>
{% if journal.enable_contact %}
<a class="list-group-item" href="javascript:;" class="contact_modal_id" data-url="#">
<span class="glyphBtn contact"></span> Contato
<span class="glyphBtn contact"></span> {% trans 'Contato' %}
</a>
Comment on lines 94 to 96
Copy link

Copilot AI Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

O link possui dois atributos class (duplicado), o que torna o HTML inválido e pode sobrescrever a classe list-group-item no navegador. Una as classes em um único atributo class (ex.: class="list-group-item contact_modal_id").

Copilot uses AI. Check for mistakes.
{% endif %}
{% if journal.social_networks %}
<a class="list-group-item" href="#followus">
<span class="glyphBtn otherNetworks"></span>
Siga-nos
{% trans 'Siga-nos' %}
</a>
{% endif %}
</ul>
Expand Down
4 changes: 2 additions & 2 deletions journalpage/templates/journalpage/includes/levelMenu.html
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@
<span class="material-icons-outlined">navigate_before</span>
</a>
<a href="#" class="btn btn-secondary">
Atual
{% trans 'Atual' %}
</a>

<a href="#" class="btn btn-secondary scielo__btn-with-icon--only --disabled">
Expand Down Expand Up @@ -119,7 +119,7 @@ <h2>&nbsp;</h2>
<div class="col-md-2 col-sm-2">
<h2>&nbsp;</h2>

<a target="_blank" href="http://analytics.scielo.org/?journal=0102-6720&amp;collection=scl" class="btn single"><span class="material-icons-outlined">show_chart</span> métricas</a>
<a target="_blank" href="http://analytics.scielo.org/?journal=0102-6720&amp;collection=scl" class="btn single"><span class="material-icons-outlined">show_chart</span> {% trans 'métricas' %}</a>

Comment on lines 120 to 123
Copy link

Copilot AI Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neste arquivo há duas chaves de tradução para o mesmo rótulo por diferença de caixa ("Métricas" vs "métricas"). Isso duplica entradas no .po. Padronize para uma única string e ajuste a apresentação (CSS/filtro) caso precise de minúsculas.

Copilot uses AI. Check for mistakes.
</div>
</div>
Expand Down
2 changes: 1 addition & 1 deletion journalpage/templates/journalpage/includes/share.html
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<span class="material-icons-outlined">share</span>
</button>
<ul class="dropdown-menu dropdown-menu-end" aria-labelledby="btnGroupDrop1">
<li><a href="javascript:window.print();" class="dropdown-item">Imprimir</a></li>
<li><a href="javascript:window.print();" class="dropdown-item">{% trans 'Imprimir' %}</a></li>
<li><a href="#" type="button" class="dropdown-item" target="_blank">RSS</a></li>
<li><a href="javascript:;" class="dropdown-item share_modal_id">E-mail</a></li>
Comment on lines +7 to 9
Copy link

Copilot AI Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

O item do menu ainda contém textos visíveis ao usuário sem tradução (por exemplo, "RSS" e "E-mail"). Para manter o objetivo do PR (i18n completo), envolva esses rótulos com {% trans %} (ou deixe explícito no PR por que devem permanecer hardcoded).

Copilot uses AI. Check for mistakes.
<li><hr class="dropdown-divider"></li>
Expand Down
Loading