feature: Upload and update package api#113
Merged
gilbert-sci merged 3 commits intomainfrom May 15, 2025
Merged
Conversation
maxhodak
approved these changes
May 13, 2025
Contributor
maxhodak
left a comment
There was a problem hiding this comment.
we should validate at the beginning of the build command that the user has all required external dependencies (i.e., docker, fpm?) and bail early if they're missing something
Contributor
Author
|
FPM is in the docker image, so it should just be docker. I think this is already being done too: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the ssh logins for deploying an app, as that is all handled by the device now.
Note: We are still waiting on the device PR, so you will need to wait to update your device to test this.
Testing