Skip to content

feature: Upload and update package api#113

Merged
gilbert-sci merged 3 commits intomainfrom
gilbert/deploy
May 15, 2025
Merged

feature: Upload and update package api#113
gilbert-sci merged 3 commits intomainfrom
gilbert/deploy

Conversation

@gilbert-sci
Copy link
Contributor

Summary

Removes the ssh logins for deploying an app, as that is all handled by the device now.

Note: We are still waiting on the device PR, so you will need to wait to update your device to test this.

Testing

  • Tested deploy with and without --package, worked

@gilbert-sci gilbert-sci requested review from emmazhou and maxhodak May 13, 2025 17:59
@gilbert-sci gilbert-sci self-assigned this May 13, 2025
Copy link
Contributor

@maxhodak maxhodak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should validate at the beginning of the build command that the user has all required external dependencies (i.e., docker, fpm?) and bail early if they're missing something

@gilbert-sci
Copy link
Contributor Author

FPM is in the docker image, so it should just be docker.

I think this is already being done too:

def ensure_docker() -> bool:
    """Check that *docker* CLI and daemon are available.

    Prints user-friendly errors and returns ``False`` if Docker cannot be used –
    allowing the caller to abort early without raising.
    """
    if shutil.which("docker") is None:
        console.print(
            "[bold red]Error:[/bold red] Docker CLI not found. Please install Docker before running this command."
        )
        return False

    try:
        subprocess.run(
            ["docker", "info"],
            stdout=subprocess.DEVNULL,
            stderr=subprocess.DEVNULL,
            check=True,
        )
        return True
    except subprocess.CalledProcessError:
        console.print(
            "[bold red]Error:[/bold red] Docker daemon does not appear to be running. Please start Docker and try again."
        )
        return False

@gilbert-sci gilbert-sci merged commit 7cffd1d into main May 15, 2025
2 checks passed
@gilbert-sci gilbert-sci deleted the gilbert/deploy branch May 15, 2025 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants