Ohlcv update #4
Merged
Ohlcv update #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @scientes,
thanks for looking into the CCXT issue with Kraken. For now, could we just disable the price preloading for Kraken? I think it's still better to use the "default" Kraken API instead of fetching the prices from other exchanges (I'd rather wait longer but have more accurate data in the end). What do you think?
As you said, I think we should merge the feature as soon as possible to the main branch. Afterwards, we can still take care of implementing the prices from trades as alternative to candles, and thereby replace the "default" Kraken API.
Also, I made some minor modifications to the warning/info console output. Use them if you want ;)