-
Notifications
You must be signed in to change notification settings - Fork 67
Adding zensical note, and aligning order of docs between sphinx and m⦠#688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
henryiii
merged 4 commits into
scientific-python:main
from
Samreay:zensical-and-docs-alignment
Nov 14, 2025
+35
β24
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm glad this is scaled back, I don't like the original statement, I don't think it was ever more popular1 than Sphinx, which is what Python itself uses. ;)
Footnotes
For some definition of popular. Stars maybe. But usage by projects, no. β©
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I was just assuming before that stars were a proportional proxy to number of projects using it (as mkdocs-material has >3x the number of stars as sphinx). But obviously there are probably (exactly) one billion older projects that just use Sphinx out of the box without ever needing to go and find it on github and press the star button. Also read over it and thought "That is way too strong an opinion to have and espouse!"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Stars are more of a measure of "ohh, that looks interesting, I'll save it for later" than actual usage. I've got lots of stars that are on projects I thought looked interesting, but I've never used. Compare pip and uv, and pip last I checked was still 75% or so of downloads from PyPI (though getting that high in so short of a time is nothing short of amazing on uv's part, still!) Also there are Python projects with more stars than Python itself; it's also often a "reward" for looking cool/new/exciting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are words I will repeat to myself about why even though my projects have few stars they might still have millions of users ;)